Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3048 closed defect (fixed)

Program Finder should strip "An" prefix from titles when sorting

Reported by: ylee@… Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythtv Version: 0.20
Severity: low Keywords: program finder sort alphabetical an
Cc: Ticket locked: no

Description

Program Finder only strips "The" and "A" from the front of program titles when sorting and displaying titles. "An" should also be stripped.

Attachments (1)

progfind_an.diff (2.7 KB) - added by stuartm 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by stuartm

Milestone: unknown0.21
Owner: changed from Isaac Richards to stuartm

Changed 13 years ago by stuartm

Attachment: progfind_an.diff added

comment:2 Changed 13 years ago by stuartm

ylee, could you test the attached patch and see if that works for you?

comment:3 Changed 13 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [12723]) Ignore 'An' along with 'The' and 'A' in the programme finder.

Closes #3048

comment:4 in reply to:  2 ; Changed 13 years ago by anonymous

Replying to stuartm:

ylee, could you test the attached patch and see if that works for you?

I apologize for not responding earlier to this patch. Under 0.20-fixes the patch applies without problems but fails during compilation (I think from something QT-related). Given the lack of complaints I trust it does not cause any problems under trunk. While I'd love to see it backported to 0.20-fixes it is certainly very much a lesser-priority issue.

comment:5 in reply to:  4 Changed 13 years ago by anonymous

I wrote earlier in anonymous:

Under 0.20-fixes the patch applies without problems but fails during compilation (I think from something QT-related).

Here's the error message:

g++ -c -pipe -pthread -I/usr/include/kde/artsc -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Wall -W -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fomit-frame-pointer -I/usr/include/freetype2 -D_REENTRANT -DPIC -fPIC  -DMMX -DUSING_FREEBOX -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DPREFIX=\"/usr\" -DLIBDIR=\"/usr/lib64\" -D_LARGEFILE_SOURCE -DUSING_OSS -DUSING_H264TOOLS -DUSING_XV -DUSING_XVMC -DUSING_XVMCW -DUSING_XVMC_VLD -DUSING_OPENGL -DUSING_OPENGL_VSYNC -DUSING_FRONTEND -DUSING_CRC_IP_NETWORK_REC -DUSING_V4L -DUSING_FIREWIRE -DUSING_DBOX2 -DUSING_FREEBOX -DUSING_HDHOMERUN -DUSING_IVTV -DUSING_DVB -DUSING_BACKEND -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -DQT_SHARED -I/usr/lib64/qt-3.3/mkspecs/default -I. -I/usr/include -I/usr/include/v4l -I/usr/include -I../.. -I.. -I../libmyth -I../libavcodec -I../libavutil -I../libmythmpeg2 -Idvbdev -Impeg -I../libmythlivemedia/BasicUsageEnvironment/include -I../libmythlivemedia/groupsock/include -I../libmythlivemedia/liveMedia/include -I../libmythlivemedia/UsageEnvironment/include -I/usr/lib64/qt-3.3/include -o progfind.o progfind.cpp
/usr/lib64/qt-3.3/include/qsqldatabase.h:63: warning: 'class QSqlDriverCreatorBase' has virtual functions but non-virtual destructor
progfind.cpp: In member function 'virtual void ProgFinder::getAllProgramData()':
progfind.cpp:1367: error: expected primary-expression before 'else'
progfind.cpp:1367: error: expected `;' before 'else'
progfind.cpp: At global scope:
progfind.cpp:1380: error: expected initializer before 'if'
progfind.cpp:1382: error: expected unqualified-id before '{' token
make[2]: *** [progfind.o] Error 1
make[2]: Leaving directory `/home/ylee/rpm/BUILD/mythtv-suite-0.20/mythtv-0.20/libs/libmythtv'
make[1]: *** [sub-libmythtv] Error 2
make[1]: Leaving directory `/home/ylee/rpm/BUILD/mythtv-suite-0.20/mythtv-0.20/libs'
make: *** [sub-libs] Error 2

I am leaving the ticket closed because, again, it is a cosmetic issue and unless someone is hankering for a (hopefully trivial) backport to 0.20-fixes there should be no rush.

Note: See TracTickets for help on using tickets.