Mythweb: Error-messages with new queue-job buttons (Ticket #2718)

[anonymous]

While trying to use the new queue-job buttons on recorded programs (see ticket #2718) I got a few error-messages entering the Recording-Details page.

Error at /var/www/mythtv/mythweb/includes/jobqueue.php, line 102:
constant(): Couldn't find constant UserJob1

Error at /var/www/mythtv/mythweb/includes/jobqueue.php, line 102:
constant(): Couldn't find constant UserJob2

Error at /var/www/mythtv/mythweb/includes/jobqueue.php, line 102:
constant(): Couldn't find constant UserJob3

Error at /var/www/mythtv/mythweb/modules/_shared/tmpl/default/header.php, line 16:
Cannot modify header information - headers already sent by (output started at /var/www/mythtv/mythweb/includes/errors.php:117)

Then I took the sql-query ...

SELECT SUBSTR(j.value, 8,1) AS jnum,
       d.data               AS name
FROM settings AS j,
     settings AS d
WHERE d.value = CONCAT("UserJobDesc", SUBSTR(j.value, 8,1))
  AND LENGTH(IFNULL(j.data, "")) > 0
  AND j.value LIKE "UserJob_"
ORDER BY jnum

... of jobqueue.php and executed it in phpMyAdmin which brought me this error-message:

#1305 - FUNCTION mythconverg.SUBSTR does not exist 

After correcting the query in changing SUBSTR to SUBSTRING the recording-details-page still throwing the errors.

I reviewed the source file again and found the line

    while ($row = $sh->fetch_assoc()) {
        $Jobs[constant('UserJob'.$row['jnum'])] = $row['name'];
    }

A constant UserJob1 etc is not defined. After changing UserJob? into 'JOB_USERJOB' it works for me. Put all this in a diff attached to this ticket.

[gosarderreisende@…]

Correction to JobQueue?.php

[gosarderreisende@…]

correct Version of Diff-File

[anonymous]

Damned ...Sorry... wrong diff!!! This is the correct one... JobQueue2.diff

[xris]

Fixed by greg in [13021]

[xris]

(In [13025]) Fix constant name, re #3199