Opened 14 years ago

Closed 14 years ago

#322 closed patch (fixed)

mythmusic cd rip fails on discs with non-audio tracks

Reported by: Brian C. Huffman <huffman@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythmusic Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Here's a patch to solve a problem where mythmusic rips fail because the cd device can not be opened. I assume it's when there are non-audio tracks.

Attachments (1)

mythplugins.diff (280 bytes) - added by Brian C. Huffman <huffman@…> 14 years ago.

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by Brian C. Huffman <huffman@…>

Attachment: mythplugins.diff added

comment:1 Changed 14 years ago by Brian C. Huffman <huffman@…>

Maybe this would be more readily accepted if I'm a little more clear on the problem.

There's a missing "cdda_close(device);" in the getSectorCount function for ripping. There's a close in the previous if statement, but if that doesn't match, the device never gets closed. This is only a one-line patch.

comment:2 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [7590]) Closes #322. Missing cdda_close() in failure case.

Note: See TracTickets for help on using tickets.