Opened 18 years ago
Closed 18 years ago
#3340 closed defect (fixed)
Recorded Programmes list (LiveTV) does not update count in group chooser droplist
| Reported by: | Owned by: | Rob Smith | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythweb | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Deleting LiveTV recordings from the Recorded Programmes page does not fully refresh the page, but updates the section of the page from where the recording was displayed to remove it.
When deleting 6 LiveTV programs from a total of 7, the group chooser droplist maintained that there were still 7 LiveTV recordings present, even when the 6 has been deleted. It was not until I forced a full refresh of the page that the count was corrected down to 1.
Attachments (1)
Change History (6)
comment:1 Changed 18 years ago by
| Resolution: | → worksforme |
|---|---|
| Status: | new → closed |
comment:2 Changed 18 years ago by
| Resolution: | worksforme |
|---|---|
| Status: | closed → reopened |
After looking through my JS error logs and testing in Firefox and IE with the same results, I then hit SVN. Looking at lines 159-160 of mythweb/modules/tv/tmpl/default/recorded.php it appears this functionality is potentially broken and untested:
159 TODO: test changing the groups dropdown on the fly. 160 I can't test it because I haven't set up any recording groups, and probably never will
I note from my testing that both the 'Show Recordings' droplist and the disk usage message at the foot of the page are successfully updated on each delete, and it is only the group droplist that is not updated on-the-fly.
I have tested this behaviour with the Default group and the LiveTV group, with the same behaviour for both. I don't have any extra recording groups defined apart from these two standard groups.
Any way I can help test this for you and get it fixed?
Cheers, Nick
comment:3 Changed 18 years ago by
After having another look at the code and some initial guidance by kormoc on IRC, I have fixed the update problem with the attached patch. I'm guessing there was a fair bit of copy'n'paste to get some rough code for this feature, which meant a few incorrect variables were being referenced in the recording group count update :)
Cheers, Nick
Changed 18 years ago by
| Attachment: | 3340_mythweb_update_recgroup_count_v1.diff added |
|---|
Patch to fix recording group count update on Recorded Programmes page
comment:4 Changed 18 years ago by
| Owner: | changed from xris to Rob Smith |
|---|---|
| Status: | reopened → new |
I can't reproduce this. Please reopen if you can get me some javascript errors.