Modify

Opened 12 years ago

Closed 11 years ago

#357 closed enhancement (wontfix)

Patch for MythGame to support diff. Hosts

Reported by: jochen Owned by: greg
Priority: minor Milestone: 0.21
Component: mythgame Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This Patch enables MythGame? to Select on a GamePlayer? if it is only for the current Host, or for all Hosts!

Attachments (2)

patch.txt (2.7 KB) - added by jochen 12 years ago.
Version 1.0 of the Patch.
patch.2.txt (3.2 KB) - added by jochen 12 years ago.
Version 2.

Download all attachments as: .zip

Change History (11)

Changed 12 years ago by jochen

Version 1.0 of the Patch.

Changed 12 years ago by jochen

Version 2.

comment:1 Changed 12 years ago by jochen

You Should use Version 2, with this, you can set the Gameplayer for every host that has already a GamePlayer?.

comment:2 Changed 12 years ago by ijr

Doesn't use existing per-host database style (ie, null for global).

comment:3 Changed 12 years ago by jochen

how can i use the MythTV settings function to set a vaule of NULL??? because i want to make the patch to fit the standart coding style.

Does it work if I change +class PlayerHostName?: public ComboBoxSetting?, public MGSetting { +public: + PlayerHostName?(const MythGamePlayerSettings?& parent): + MGSetting(parent, "hostname") { + setLabel(QObject::tr("Hostname")); + addSelection("(all Clients)", "*"); + addSelection("(current Client)", gContext->GetHostName?());

to

+class PlayerHostName?: public ComboBoxSetting?, public MGSetting { +public: + PlayerHostName?(const MythGamePlayerSettings?& parent): + MGSetting(parent, "hostname") { + setLabel(QObject::tr("Hostname")); + addSelection("(all Clients)", NULL); + addSelection("(current Client)", gContext->GetHostName?());

comment:4 Changed 12 years ago by jochen

sorry to use this for discussion, but i saw i was wrong, that can't work. if anyonle could help.

comment:5 Changed 12 years ago by greg

  • Owner changed from ijr to greg

I believe Isaac was referring to how your patch to dbcheck.cpp

sets that columns default value to '*' instead of NULL.

However I'm rejecting this patch as it is right now not just for that, but because it does not properly address the rest of the application to make this work.

If you want per host emulators then you should only display the games in the gametree that apply to that host(or provide an indicator of what is not available to them). Which means you have to update the gametree code to support this new per host feature, and means changing how the gamescan information is entered in the database as it does not take into account that a emulator might not be available on all frontends.

I wont be applying any patch that doesn't address the rest of this. At this point it's little more than a new setting on a page.

comment:6 Changed 12 years ago by jochen

  • Type changed from defect to enhancement

This Patch in the second version is not only a config setting.

In the Gametree also only the games for the aviable systems are visible.

comment:7 Changed 12 years ago by greg

  • Milestone set to 0.20
  • Status changed from new to assigned

comment:8 Changed 12 years ago by greg

  • Milestone changed from 0.20 to 0.21

comment:9 Changed 11 years ago by greg

  • Resolution set to wontfix
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed The owner will remain greg.
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.