Opened 17 years ago
Closed 15 years ago
#3711 closed enhancement (fixed)
mythvideo: show bookmark menu for videos also
| Reported by: | anonymous | Owned by: | robertm |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.22 |
| Component: | Plugin - MythVideo | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Mythvideo will ask to play a DVD from the beginning or bookmark if a bookmark exists. This patch adds this for videos also.
Attachments (3)
Change History (14)
Changed 17 years ago by
| Attachment: | mythvideo-bookmark.patch added |
|---|
Changed 16 years ago by
| Attachment: | mythvideo-bookmark.diff added |
|---|
comment:1 Changed 16 years ago by
| Version: | unknown → head |
|---|
Changed 15 years ago by
| Attachment: | mythvideo-bookmark.2.diff added |
|---|
updated for trunk. Will not work with 0.21-fixes.
comment:3 Changed 15 years ago by
| Status: | new → assigned |
|---|
comment:4 Changed 15 years ago by
| Status: | assigned → infoneeded |
|---|
Can you update this patch as a MythUI Popup? This is worthwhile, but it needs to be MythUI to be committed.
comment:5 Changed 15 years ago by
| Milestone: | unknown → 0.22 |
|---|
comment:6 Changed 15 years ago by
| Status: | infoneeded → assigned |
|---|
comment:7 Changed 15 years ago by
| Owner: | changed from Anduin Withers to stuartm |
|---|
comment:8 Changed 15 years ago by
| Status: | assigned → accepted |
|---|
Doing this properly is going to take a lot of changes which can't be done now we're in feature freeze. I do think something needs to be done for 0.22, so I'll accept the supplied patch with some small changes.
comment:9 Changed 15 years ago by
| Owner: | changed from stuartm to robertm |
|---|---|
| Status: | accepted → started |
comment:10 Changed 15 years ago by
| Component: | mythvideo → Plugin - MythVideo |
|---|
comment:11 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | started → closed |
(In [22228]) Fixes #3711. Allows one to jump to the bookmark when playing back MythVideo?/non-recordings files. This is a stopgap solution until we replace this with a MythUI popup, but it sidesteps a potential issue where a user sets a bookmark in a video with no seektable, and then when they try to play it back, an attempt to seek to the bookmark will fail, as will playback of the file. This leaves the file in a 'broken' state which requires manually removing the bookmark from the DB. Now the user can simply choose 'Play from beginning' on such files.
Updated for SVN 15223