Opened 12 years ago

Closed 10 years ago

#3711 closed enhancement (fixed)

mythvideo: show bookmark menu for videos also

Reported by: anonymous Owned by: robertm
Priority: minor Milestone: 0.22
Component: Plugin - MythVideo Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Mythvideo will ask to play a DVD from the beginning or bookmark if a bookmark exists. This patch adds this for videos also.

Attachments (3)

mythvideo-bookmark.patch (3.6 KB) - added by maverik044 12 years ago.
mythvideo-bookmark.diff (3.2 KB) - added by Bill <level42@…> 12 years ago.
Updated for SVN 15223
mythvideo-bookmark.2.diff (3.3 KB) - added by wstewart@… 11 years ago.
updated for trunk. Will not work with 0.21-fixes.

Download all attachments as: .zip

Change History (14)

Changed 12 years ago by maverik044

Attachment: mythvideo-bookmark.patch added

Changed 12 years ago by Bill <level42@…>

Attachment: mythvideo-bookmark.diff added

Updated for SVN 15223

comment:1 Changed 12 years ago by danielk

Version: unknownhead

Changed 11 years ago by wstewart@…

Attachment: mythvideo-bookmark.2.diff added

updated for trunk. Will not work with 0.21-fixes.

comment:2 Changed 11 years ago by wstewart@…

updated patch for trunk

comment:3 Changed 11 years ago by Dibblah

Status: newassigned

comment:4 Changed 10 years ago by robertm

Status: assignedinfoneeded

Can you update this patch as a MythUI Popup? This is worthwhile, but it needs to be MythUI to be committed.

comment:5 Changed 10 years ago by stuartm

Milestone: unknown0.22

comment:6 Changed 10 years ago by stuartm

Status: infoneededassigned

comment:7 Changed 10 years ago by stuartm

Owner: changed from Anduin Withers to stuartm

comment:8 Changed 10 years ago by stuartm

Status: assignedaccepted

Doing this properly is going to take a lot of changes which can't be done now we're in feature freeze. I do think something needs to be done for 0.22, so I'll accept the supplied patch with some small changes.

comment:9 Changed 10 years ago by robertm

Owner: changed from stuartm to robertm
Status: acceptedstarted

comment:10 Changed 10 years ago by stuartm

Component: mythvideoPlugin - MythVideo

comment:11 Changed 10 years ago by robertm

Resolution: fixed
Status: startedclosed

(In [22228]) Fixes #3711. Allows one to jump to the bookmark when playing back MythVideo?/non-recordings files. This is a stopgap solution until we replace this with a MythUI popup, but it sidesteps a potential issue where a user sets a bookmark in a video with no seektable, and then when they try to play it back, an attempt to seek to the bookmark will fail, as will playback of the file. This leaves the file in a 'broken' state which requires manually removing the bookmark from the DB. Now the user can simply choose 'Play from beginning' on such files.

Note: See TracTickets for help on using tickets.