Opened 12 years ago

Closed 12 years ago

#3884 closed defect (fixed)

mytharchive: aspect ratio of titles controlled by chapter menu aspect ratio

Reported by: Russell Mora <rd.mora@…> Owned by: paulh
Priority: minor Milestone: 0.21
Component: mytharchive Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Currently the aspect ratio that mytharchive uses for titles is the same as the chaptermenuAspectRatio setting, if set. This does not make sense to me, for example says I want the chapter menus in 4:3 (because my broken DVD player always screws up 16:9 menus) this means that the title is specified as 4:3 as well even if it is 16:9. As such I have just removed the checking of chaptermenuAspectRatio from my version of the script - it just checks the title's actual aspect ratio instead. To me this seems like the right thing to do, so I thought I better submit it for your consideration.

Here is the patch - it looks more confusing that it is due to the indentation changes. It just removes the check of chaptermenuAspectRatio:

Index: mytharchive/mythburn/scripts/mythburn.py =================================================================== --- mytharchive/mythburn/scripts/mythburn.py (revision 14309) +++ mytharchive/mythburn/scripts/mythburn.py (working copy) @@ -2473,19 +2473,12 @@

video = dvddom.createElement("video") video.setAttribute("format",videomode)

  • # set the right aspect ratio
  • if chaptermenuAspectRatio == "4:3":
  • video.setAttribute("aspect", "4:3")
  • elif chaptermenuAspectRatio == "16:9":

+ # ALWAYS use same aspect ratio as the video + if getAspectRatioOfVideo(itemnum) > aspectRatioThreshold:

video.setAttribute("aspect", "16:9") video.setAttribute("widescreen", "nopanscan")

  • else:
  • # use same aspect ratio as the video
  • if getAspectRatioOfVideo(itemnum) > aspectRatioThreshold:
  • video.setAttribute("aspect", "16:9")
  • video.setAttribute("widescreen", "nopanscan")
  • else:
  • video.setAttribute("aspect", "4:3")

+ else: + video.setAttribute("aspect", "4:3")

menus.appendChild(video)

Change History (2)

comment:1 Changed 12 years ago by paulh

Milestone: unknown0.21

comment:2 Changed 12 years ago by paulh

Resolution: fixed
Status: newclosed

(In [14314]) When creating the xml file that is passed to DVDAuthor set the titles aspect ratio to that of the video and not the one chosen for the chapter menu.

Closes #3884.

Note: See TracTickets for help on using tickets.