Opened 12 years ago

Closed 12 years ago

#3959 closed patch (fixed)

PATCH mpegrecorder.cpp - checking volume range before setting it

Reported by: anonymous Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

mpegrecorder.cpp - checking volume range before setting it (instead of previously used 0-65536 range).

Attachments (2)

mpegrecorder_wolume_ctl.patch​ (965 bytes) - added by mark_kiddy@… 12 years ago.
3959-v1.patch​ (1.2 KB) - added by danielk 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by mark_kiddy@…

Attachment: mpegrecorder_wolume_ctl.patch​ added

comment:1 Changed 12 years ago by danielk

Owner: changed from Isaac Richards to danielk

Changed 12 years ago by danielk

Attachment: 3959-v1.patch​ added

comment:2 Changed 12 years ago by danielk

Mark, can you try the attached? It tries to be a little more correct in the volume calculation using floats and then it uses min & max to make sure we don't go out of range at the extremes.

comment:3 Changed 12 years ago by danielk

Milestone: unknown → 0.21

comment:4 Changed 12 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [14576]) Fixes #3959. Properly checks range of volume control in mpegrecorder before setting the value.

This is done for correctness and is also a step in allowing mpegrecorder to be used with any driver implementing the v4l2 mpeg recording API and not just ivtv cards.

Note: See TracTickets for help on using tickets.