Opened 18 years ago
Closed 18 years ago
#4042 closed defect (fixed)
0.20-fixes won't build on macines with DVB API < 3.1
Reported by: | anonymous | Owned by: | danielk |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | 0.20-fixes |
Severity: | medium | Keywords: | |
Cc: | mail@… | Ticket locked: | no |
Description
The current revision of the 0.20-fixes branch has this code in frequencytables.cpp, lines 78 and 82:
fe_type type = FE_QPSK; type = (_cardtype.upper() == "ATSC") ? FE_ATSC : type;
However, the same revision's dvbtypes.h has this code: (Lines 39-44)
#if (DVB_API_VERSION >= 3 && DVB_API_VERSION_MINOR >= 1) # define USE_ATSC #else #warning DVB API version < 3.1 #warning ATSC will not be supported using the Linux DVB drivers # define FE_ATSC (FE_OFDM+1)
Thus, compiling the release on a system with a DVB API < 3.1 (in my case a Gentoo 2.6.10 with linuxdvb 1.1.1) resulted in a compilation error:
In file included from dvbchannel.h:22, from frequencytables.h:17, from frequencytables.cpp:1: dvbtypes.h:42:2: warning: #warning DVB API version < 3.1 dvbtypes.h:43:2: warning: #warning ATSC will not be supported using the Linux DVB drivers frequencytables.cpp: In constructor `TransportScanItem::TransportScanItem(int, const QString&, const QString&, const QString&, const DTVTransport&, unsigned int)': frequencytables.cpp:82: error: invalid conversion from `int' to `fe_type'
Changeset 11702 removed the offending code from frequencytables.cpp, however I didn't test out whether I could get it to compile with the rest of 0.20-fixes on my system.
Change History (2)
Note: See
TracTickets for help on using
tickets.
Please reopen if you can confirm that [11702] didn't fix the problem.