Opened 14 years ago

Closed 13 years ago

#422 closed enhancement (wontfix)

New method of customizing Myth menus

Reported by: jcaputo1 at comcast.net Owned by: Isaac Richards
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

I submitted a patch for this a couple of months ago, but it got lost on the mailing list in the transition from CVS to Subversion. See here and here for more info. I've been running with this patch for 3-4 months with no problems. I'll attach a patch against recent SVN.

Attachments (2)

menu.diff (1.6 KB) - added by jcaputo1 (at) comcast.net 14 years ago.
Patch for new menu customization method
userMenuItems.xml (366 bytes) - added by jcaputo1 (at) comcast.net 14 years ago.
Sample ~/.mythtv/userMenuItems.xml file

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by jcaputo1 (at) comcast.net

Attachment: menu.diff added

Patch for new menu customization method

Changed 14 years ago by jcaputo1 (at) comcast.net

Attachment: userMenuItems.xml added

Sample ~/.mythtv/userMenuItems.xml file

comment:1 Changed 14 years ago by jcaputo1 (at) comcast.net

Just thought I'd note, this works fine although it can sometimes cause your custom menu items to show up in more than one location, unintentionally. Case in point: in the sample file, the "Misc" menu is added to a menu called "MAIN". Under the "Classic" menu theme, this is the top-level menu. Under the "DVR" menu theme, this applies to *both* the main menu (mainmenu.xml) and the Utils menu (util_menu.xml), causing the 'Misc' menu to show up in both, when I really only wanted it in one.

The fix would probably be (as suggested in my original post on the ML) to enforce name uniqueness on mythmenu container names. Another extension to this could be to add menu theme awareness, so that a user item could be placed in different containers depending on the theme in use.

Nevertheless, it's perfectly serviceable as-is.

-JAC

comment:2 Changed 14 years ago by jcaputo1 (at) comcast.net

Anyone care to comment on this? I know folks are busy with bigger issues, so I'll make it multiple choice:

  1. the whole idea sucks, go away
  2. good idea, bad implementation; re-work and re-submit
  3. sounds good, just haven't had a chance to look at it

BTW, I saw changeset [7394]. Thanks, Bruce.

-JAC

comment:3 Changed 14 years ago by danielk

Issac is doing a big UI reworking so I think most of us are just not looking at any UI XML parsing patches since they will probably be obsoleted by MythUI which has a new XML parser among it's features.

comment:4 Changed 14 years ago by danielk

Milestone: 0.20
Version: head

comment:5 Changed 13 years ago by Isaac Richards

Resolution: wontfix
Status: newclosed

Patch doesn't apply anymore.

Note: See TracTickets for help on using tickets.