Opened 12 years ago

Closed 12 years ago

#4534 closed patch (fixed)

mytharchive doesn't make final chapter mark when using fixed spacing

Reported by: thrantastic@… Owned by: paulh
Priority: minor Milestone: 0.21
Component: mytharchive Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Whenever the mythburn.py script is asked to set DVD chapter marks with a fixed spacing, it adds one less chapter than would be expected. As an example, consider a 24 minute video with chapter segment length of 5 min. Mytharchive will set chapter marks at 0, 5, 10, and 15 minutes but not one at 20 minutes as would be expected. This is because it places floor(lengthofvideo/segment) = 4 marks when it should do floor(lengthofvideo/segment + 1) = 5 marks. I've attached a patch that does this.

Attachments (1)

mythburn-fixchapters.diff (646 bytes) - added by thrantastic@… 12 years ago.
Patch to fix fixed length chapter markings in mythburn.py

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by thrantastic@…

Attachment: mythburn-fixchapters.diff added

Patch to fix fixed length chapter markings in mythburn.py

comment:1 Changed 12 years ago by thrantastic@…

I should add that the attached patch is not quite up to date with svn head, but it should still be trivial to apply.

comment:2 Changed 12 years ago by paulh

Milestone: unknown0.21
Status: newaccepted

comment:3 Changed 12 years ago by paulh

Resolution: fixed
Status: acceptedclosed

(In [15613]) When using a DVD menu theme that uses fixed length chapters (every 5 minutes by default) the script was missing of the last chapter mark.

Patch by thrantastic (at) gmail.com. Closes #4534.

Note: See TracTickets for help on using tickets.