Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#47 closed enhancement (invalid)

Replace MYTH_BINARY_VERSION with svn derived version string

Reported by: Dibblahmythml0015@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Currently, MYTH_BINARY_VERSION is defined in libs/libmyth/mythcontext.h. This would be better done (As suggested earlier by Isaac) as 'real' svn based versions. For example:

"release-0-18-1.2005-05-14.6399" "trunk.2005-07-01.6757"

Attachments (1)

mythsvnversions.patch​ (922 bytes) - added by Dibblahmythml0015@… 14 years ago.
This is the first part of the implementation. It adds getting the version string from the svn information into mythconfig.h

Download all attachments as: .zip

Change History (2)

Changed 14 years ago by Dibblahmythml0015@…

Attachment: mythsvnversions.patch​ added

This is the first part of the implementation. It adds getting the version string from the svn information into mythconfig.h

comment:1 Changed 14 years ago by Isaac Richards

Resolution: → invalid
Status: new → closed

No, MYTH_BINARY_VERSION shouldn't change like this. It's an ABI version, not a checkout version. This patch would require the user to recompile all their plugins for absolutely no reason.

Additionally, it shouldn't go in the configure script. Not running configure would cause it to not update the checkout number, and this wouldn't work at all in the case of a release where there aren't any .svn directories.

If this were to be done right, it'd be contained in a separate .cpp file (not a .h) so it doesn't trigger recompiles of large chunks of the code. It'd have to be updated on every checkin as well.

Note: See TracTickets for help on using tickets.