Opened 12 years ago

Closed 12 years ago

#4748 closed patch (fixed)

Add DB port to database backup command

Reported by: sphery <mtdean@…> Owned by: danielk
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch, mythtv-DB_port_for_backups.patch , adds the --port argument to the database backup command when the DatabaseParams? dbPort is specified.

Attachments (2)

mythtv-DB_port_for_backups.patch (1.5 KB) - added by sphery <mtdean@…> 12 years ago.
mythtv-4748-DB_port_for_backups.patch (1.6 KB) - added by sphery <mtdean@…> 12 years ago.
Updated patch for use if committed after #4760

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by sphery <mtdean@…>

comment:1 Changed 12 years ago by danielk

Milestone: unknown0.21
Owner: changed from Isaac Richards to danielk
Status: newassigned

comment:2 Changed 12 years ago by danielk

Milestone: 0.210.22
Version: 0.21-fixeshead

Sorry, I ran out of time on this one.

I don't want to commit this now in case it causes problems that won't be reported for a few days.. The existing backup code should work with any standard MythTV install and all packaged MythTV installs.

comment:3 Changed 12 years ago by sphery <mtdean@…>

This should probably be closed as wontfix. Fixing 0.21-fixes to handle non-standard DB ports is probably unnecessary as 0.21 doesn't really rely on nor advertise the backup functionality (so users running on non-standard ports can do their pre-upgrade backup manually) and this patch will be obsoleted by #4760.

Changed 12 years ago by sphery <mtdean@…>

Updated patch for use if committed after #4760

comment:4 Changed 12 years ago by sphery <mtdean@…>

OK, it turns out this is not obsoleted by #4760 since we're keeping the "built-in" backup capability (in addition to adding script-based backup). (I forgot I decided to keep the patches separate for accountability.)

mythtv-4748-DB_port_for_backups.patch is an updated patch, tested with post-Qt4 trunk. The only change to it is to the line numbers to allow it to apply after #4760 without offsets.

comment:5 Changed 12 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [17884]) Fixes #4748. Uses the DB port for mysqldump if the port is set for regular DB access.

Note: See TracTickets for help on using tickets.