Opened 17 years ago
Closed 17 years ago
#4837 closed defect (fixed)
check of shm_img pointer in ChromaKeyOSD::AllocImage() should be done before shm_img is dereferenced
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | mythtv | Version: | 0.21-fixes |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
shm_img is dereferenced before it is checked:
uint size = shm_img->bytes_per_line * (shm_img->height+1) + 128; X11U; if (shm_img)
Which means the caller of this member function will segfault if the shm call didn't work.
Attachments (1)
Change History (4)
Changed 17 years ago by
Attachment: | libs_libmythtv_osdchromakey.cpp-move-up-null-check.patch added |
---|
comment:1 Changed 17 years ago by
Milestone: | 0.21 → 0.22 |
---|
comment:2 Changed 17 years ago by
Owner: | changed from Isaac Richards to danielk |
---|---|
Status: | new → assigned |
Note: See
TracTickets for help on using
tickets.
moves the null pointer check up before the first dereference