Opened 12 years ago

Closed 12 years ago

#4889 closed defect (fixed)

FreeSurround does not initialize processed_size in ctor

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

FreeSurround? does not initialize processed_size in ctor

Attachments (1)

libs_libmythfreesurround_freesurround.cpp-init-processed_size.patch​ (758 bytes) - added by Erik Hovland <erik@…> 12 years ago.
Initialize processed_size to -1 in FreeSurround? ctor

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythfreesurround_freesurround.cpp-init-processed_size.patch​ added

Initialize processed_size to -1 in FreeSurround? ctor

comment:1 Changed 12 years ago by Mark Spieth

0 is ok too.

comment:2 Changed 12 years ago by Erik Hovland <erik@…>

If I change it to zero, is it more likely that the patch will be accepted? When int is used I usually initialize them to -1 out of habit.

comment:3 Changed 12 years ago by markpsieth

doesnt matter either way. it is acceptable as is or as 0.

comment:4 Changed 12 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [17519]) Fixes #4886. Fixes #4887. Fixes #4889. Fixes a few uninitialized variables in ctor problems.

Note: See TracTickets for help on using tickets.