Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#49 closed patch (fixed)

update of analog scan

Reported by: john.pullan@… Owned by: taylor
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

It's been pointed out to me that Analog scan does not make use of the Channel class and won't therefore work with V4L v1. (There are other issues with the code as well). I had hoped to fix these problems but I don't think I'll get the time. So I offer this patch to revert the Analog scan functionallity back out.

Attachments (2)

analogrevert.diff (6.2 KB) - added by john.pullan@… 14 years ago.
diff to revert analog scan back out
analogscan.patch (14.5 KB) - added by John Pullan <john.pullan@…> 14 years ago.
makes analog scan use the channel class.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by john.pullan@…

Attachment: analogrevert.diff added

diff to revert analog scan back out

comment:1 Changed 14 years ago by anonymous

Summary: removeal of analog scan removal of analog scan

forgot to point out the obvious of removing analogscan.* from the repositry.

comment:2 Changed 14 years ago by Isaac Richards

Owner: changed from Isaac Richards to taylor

Taylor can decide to remove it or not - I don't see the need, though.

comment:3 Changed 14 years ago by john.pullan@…

Summary: removal of analog scan update of analog scan

Apologies, I found some time yesterday. The new code uses Channel (addition of one function). I'll post it up here later today for your perusal.

(Code should now work for both v4l and v4l2)

Changed 14 years ago by John Pullan <john.pullan@…>

Attachment: analogscan.patch added

makes analog scan use the channel class.

comment:4 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [6806]) Patch from John Pullan to make the analog scan class use the Channel object, and significantly reduce the amount of duplicated code in it. Closes #49.

Note: See TracTickets for help on using tickets.