Opened 14 years ago
Closed 14 years ago
#493 closed defect (fixed)
Crash on number press with SmartChannelChange
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | critical | Milestone: | 0.19 |
| Component: | mythtv | Version: | head |
| Severity: | high | Keywords: | |
| Cc: | Ticket locked: | no |
Description
If you enable SmartChannelChange? and play a recording, mythfrontend crashes on a number press.
The issue with SmartChannelChange? enabled, a number press causes a call to ChannelCommit?(), which apparently causes problems. I have not traced where the eventual crash takes place, but presume it's a cause of querying or setting the channel when not in live TV.
Patch is simple and follows.
It may have implications if you are watching a recording that was still being recorded. I've noticed that I was somehow able to change the channel in this mode. I do not view this as a feature and have not tried to reproduce the behavior predictably. I suspect that this is not intended behavior anyway.
Attachments (1)
Change History (5)
Changed 14 years ago by
| Attachment: | channel.patch added |
|---|
comment:1 Changed 14 years ago by
Belt and suspenders fix.
- Do not call ChannelCommit?() from ChannelKey?() unless StateIsLiveTV().
- If !StateIsLiveTV(), then ChannelCommit?() calls ChannelClear?() and returns without going further.
comment:2 Changed 14 years ago by
| Milestone: | 0.19 |
|---|
comment:3 Changed 14 years ago by
| Milestone: | → 0.19 |
|---|---|
| Owner: | changed from Isaac Richards to danielk |
channelcrash.patch