Opened 17 years ago
Closed 17 years ago
Last modified 17 years ago
#4981 closed defect (fixed)
AudioOutput cleanup
| Reported by: | danielk | Owned by: | danielk |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythtv | Version: | unknown |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
When reviewing some audio patches I got irked by some const correctness and other API problems in the AudioOutput? classes. So I started doing some cleanup..
Attachments (5)
Change History (7)
Changed 17 years ago by
| Attachment: | 4981-v1.patch added |
|---|
Changed 17 years ago by
| Attachment: | 4981-v3.patch added |
|---|
2nd draft with audiosettings.{h,cpp} missing in last patch..
Changed 17 years ago by
| Attachment: | audiooutput.patch added |
|---|
This should be applied on top of 4981-v3.patch
comment:1 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [16723]) Fixes #4981. AudioOutput? cleanup.
Some const correctness plus simplifying the constructors and Reconfigure so new optional audio paramameters can be added without needing to touch every audio file.
Refs #4764. I wanted to fix this after trying to fix some const problems in Steve Adeff's patch and running into a bunch of the that went all the way back to AudioOutput? and AudioOutputBase?.
This has been tested with ALSA/OSS/OSX/MINGW audio and compiles on all three platforms.
This does require a "make distclean" and rebuilding the plugins as the Audio API is slightly changed.
first draft of AudioOutput? cleanup