Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4981 closed defect (fixed)

AudioOutput cleanup

Reported by: danielk Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When reviewing some audio patches I got irked by some const correctness and other API problems in the AudioOutput? classes. So I started doing some cleanup..

Attachments (5)

4981-v1.patch (62.7 KB) - added by danielk 12 years ago.
first draft of AudioOutput? cleanup
4981-v2.patch (96.4 KB) - added by danielk 12 years ago.
2nd draft
4981-v3.patch (94.7 KB) - added by danielk 12 years ago.
2nd draft with audiosettings.{h,cpp} missing in last patch..
audiooutput.patch (3.2 KB) - added by andrei@… 12 years ago.
This should be applied on top of 4981-v3.patch
4981-v4.patch (97.1 KB) - added by danielk 12 years ago.
Updated patch with Andrei's fix

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by danielk

Attachment: 4981-v1.patch added

first draft of AudioOutput? cleanup

Changed 12 years ago by danielk

Attachment: 4981-v2.patch added

2nd draft

Changed 12 years ago by danielk

Attachment: 4981-v3.patch added

2nd draft with audiosettings.{h,cpp} missing in last patch..

Changed 12 years ago by andrei@…

Attachment: audiooutput.patch added

This should be applied on top of 4981-v3.patch

Changed 12 years ago by danielk

Attachment: 4981-v4.patch added

Updated patch with Andrei's fix

comment:1 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [16723]) Fixes #4981. AudioOutput? cleanup.

Some const correctness plus simplifying the constructors and Reconfigure so new optional audio paramameters can be added without needing to touch every audio file.

Refs #4764. I wanted to fix this after trying to fix some const problems in Steve Adeff's patch and running into a bunch of the that went all the way back to AudioOutput? and AudioOutputBase?.

This has been tested with ALSA/OSS/OSX/MINGW audio and compiles on all three platforms.

This does require a "make distclean" and rebuilding the plugins as the Audio API is slightly changed.

comment:2 Changed 12 years ago by danielk

(In [16728]) Refs #4981. Fixes a compile error for the aacdecoder in MythMusic.

Note: See TracTickets for help on using tickets.