QImage takes an int for the number of colors (which means it can only take 2 Mi colors)

[Erik Hovland <erik@…>]

QImage takes a parameter in its constructor that specifies the number of colors the image can have. That parameter type is an int. Which can only go to 2 Mibi colors. In a few places where QImages are used they are given 4 Mibi colors. Which is an integer overflow value to a constructor. Probably nothing bad is happening. But it is likely better to give the integer max instead of an overflow value.

[Erik Hovland <erik@…>]

changes the 4Mibi value in the ctor call to the INT_MAX macro from the C library

[stuartm]

Since this particular constructor doesn't exist in QT4 the correct fix will be applied as part of the QT4 port. In QT4 we use a format enum value instead to specify the colour depth. e.g QImage::Format_RGB32

[Erik Hovland <erik@…>]

OK, so the port has happened and this constructor has not changed. So I am reopening the ticket and submitting a patch that uses the QT4 enum based constructor as Stuart mentions.

[Erik Hovland <erik@…>]

Same patch, but uses the QT4 ctor and enum

[stuartm]

The QT4 port is far from complete. We've converted to QT4 + QT3Support and we're now slowly moving towards full QT4 which would include replacing QT3 only classes/methods with QT4 equivalents.

Thanks for the patch however :)

[stuartm]

(In [17059]) Convert QImage constructor to the QT4 format using an enum value to define depth, number of colours and endianness. I didn't use the patch from Eric Hovland as it failed to remove the defunct depth argument, but thanks anyway. Fixes #5179