Opened 14 years ago

Closed 14 years ago

#537 closed defect (fixed)

playbackbox doesn't observe "Newest recordings first" checkbox when sorting by original air date.

Reported by: gregturn@… Owned by: bjm
Priority: minor Milestone: 0.19
Component: mythtv Version:
Severity: medium Keywords: playbackbox original airdate
Cc: Ticket locked: no

Description

I was checking out the option in TV Settings->Playback about sorting by Original Airdate, and noticed that it was hardcoded to only sort one way. It didn't observe the checkbox that indicates "Newest Recording First" whether it was on or off.

I have coded a patch to observe this checkbox by editing playbackbox.cpp. I created a copy of the original comp_originalAirdate and swapped the "return -1" and "return 1" statements. To clarify which method served which purpose, I renamed these two sort routines as comp_originalAirDateDesc and comp_originalAirDateAsc.

Attachments (1)

sort_patch.txt (1.7 KB) - added by gregturn@… 14 years ago.
Patch to sort ascending and descending by original air date.

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by gregturn@…

Attachment: sort_patch.txt added

Patch to sort ascending and descending by original air date.

comment:1 Changed 14 years ago by anonymous

Type: defectpatch

comment:2 Changed 14 years ago by bjm <bjm@…>

Milestone: 0.19
Owner: changed from Isaac Richards to anonymous
Status: newassigned
Type: patchdefect

I'll take this. The same thing applies to programid sort and I need it to handle repositioning after deleting for both orderings and the Delete page context.

comment:3 Changed 14 years ago by bjm <bjm@…>

Owner: changed from anonymous to bjm
Status: assignednew

comment:4 Changed 14 years ago by bjm

Resolution: fixed
Status: newclosed

(In [7651]) Honor the "Newest recordings first" flag for programid sort and originalairdate sort as well as by record date. For all six forward and reverse cases, the per-title appear to be correct with a mixture of programids and originalairdates. Deleting an item from the middle of a list repositions the highlight sanely in all six cases.

One problem. It appears that recorded.originalairdate gets erroneously set to the record date when there was no originalairdate in the program data, i.e. "Paid Programming" was not aired for the first time ever today. This will be fixed separately.

closes #537

Note: See TracTickets for help on using tickets.