Opened 11 years ago

Closed 11 years ago

#5559 closed patch (fixed)

OS X Build Failure - mythmainwindow.cpp

Reported by: grhowes@… Owned by: Nigel
Priority: major Milestone: unknown
Component: mythtv Version: head
Severity: high Keywords: OS X
Cc: Ticket locked: no

Description

There appear to be a couple of typos (AppleRemote? instead of appleRemote) in the current branch when the USING_APPLEREMOTE flag is set. Also the compiler that is used when XCode 3.0 is installed chokes on the constructor (or lack thereof) for the appleRemote member variable of MythMainWindowPrivate?

Attachments (1)

mythmainwindow.diff (1.6 KB) - added by grhowes@… 11 years ago.
patch for mythmainwindow.cpp

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by grhowes@…

Attachment: mythmainwindow.diff added

patch for mythmainwindow.cpp

comment:1 Changed 11 years ago by anonymous

I don't think they are typos, it is just that the bizarre class structure of AppleRemote? hasn't been ported properly after [17830]. I have a patch that creates a static AppleRemote? * AppleRemote::Get(), but haven't actually got it to work (i.e. send events into the window yet). For now, I thought it was better to have a version that didn't build then one that didn't work.

comment:2 Changed 11 years ago by George Nassas <gnassas@…>

+1 for a prompt commit of this. One part of it fixes an obvious misspelling and the AppleRemote? reference clearly needs to be initialized in a constructor. I was preparing an identical patch when this ticket showed up.

comment:3 Changed 11 years ago by <JR.myth@…>

Could someone please also apply this patch in the mythtv-vid branch?

Thanks!

-jr-

comment:4 Changed 11 years ago by anonymous

With this patch applied, when I try to use the remote I get 20 lines of:

IOHIDQueueClass: Queue size mismatch (0, 24)

for each key press.

comment:5 Changed 11 years ago by Nigel

Owner: changed from Isaac Richards to Nigel
Status: newaccepted

comment:6 Changed 11 years ago by Nigel

(In [17888]) Get this compiling again after [17830]. Refs #5559.

comment:7 Changed 11 years ago by Nigel

Resolution: fixed
Status: acceptedclosed

As of [17894] this should be fixed in trunk, and [17895] in the mythtv-vid branch.

Note: See TracTickets for help on using tickets.