Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6159 closed enhancement (fixed)

Add Screenshot as additional metadata type to videometadata

Reported by: robert.mcnamara@… Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: head
Severity: medium Keywords: MythVideo Screenshot
Cc: Ticket locked: no

Description

This patch adds screenshot as an optional eligible image type (in addition to coverfile) in videometadata, allowing this type of effect:

http://www.fecitfacta.com/MV_Screenshots.png

Attachments (17)

MVScreenshots.diff (15.7 KB) - added by robert.mcnamara@… 11 years ago.
Patch to add screenshot metadata to MV
MVScreenshots.2.diff (26.3 KB) - added by robert.mcnamara@… 11 years ago.
Couple of things missed, adds UI changes
MVnewmeta.diff (39.0 KB) - added by robert.mcnamara@… 11 years ago.
Add support for banners and fanart
MVnewmeta.2.diff (38.8 KB) - added by robert.mcnamara@… 11 years ago.
A hunk from another patch made it in to last one.
MVnewmeta.3.diff (38.8 KB) - added by robert.mcnamara@… 11 years ago.
A couple small fixes, otherwise same as above.
MV-fanartdownloader.diff (12.6 KB) - added by robert.mcnamara@… 11 years ago.
Supplement patch to add fanart downloads
MV-fanartdownloader.2.diff (13.1 KB) - added by robert.mcnamara@… 11 years ago.
Fix to keep Fanart from Overwriting Coverfile, supercedes previous.
MVnewmeta.4.diff (44.5 KB) - added by robert.mcnamara@… 11 years ago.
Adds file selector popup for screenshots, banner, fanart
MVnewmeta.5.diff (45.2 KB) - added by robert.mcnamara@… 11 years ago.
Accounts for changes to file browser, minor fixes
MVnewmeta.6.diff (44.4 KB) - added by robert.mcnamara@… 11 years ago.
removes one inadvertantly added hunk
MVnewmeta.7.diff (44.9 KB) - added by robert.mcnamara@… 11 years ago.
Improves a few variable names
MV-fanartdownloader.3.diff (13.2 KB) - added by robert.mcnamara@… 11 years ago.
Update to the Fanart Downloader (supplemental, optional patch)
MVnewmeta.8.diff (44.9 KB) - added by robert.mcnamara@… 11 years ago.
updates settings table values to be mythvideo.VALUE for consistency
MVnewmeta.9.diff (45.2 KB) - added by robert.mcnamara@… 11 years ago.
Accounts for MythVideo? SG changes
MVnewmeta.10.diff (47.8 KB) - added by robert.mcnamara@… 11 years ago.
Ports patch to use Storage Groups
MVnewmeta.11.diff (48.0 KB) - added by robert.mcnamara@… 11 years ago.
bugfix patch
fanart-download.final.diff (13.3 KB) - added by robert.mcnamara@… 11 years ago.
Fix for IsHostSet?() breakage, and updated fanart downloader

Download all attachments as: .zip

Change History (25)

Changed 11 years ago by robert.mcnamara@…

Attachment: MVScreenshots.diff added

Patch to add screenshot metadata to MV

Changed 11 years ago by robert.mcnamara@…

Attachment: MVScreenshots.2.diff added

Couple of things missed, adds UI changes

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.diff added

Add support for banners and fanart

comment:1 Changed 11 years ago by robert.mcnamara@…

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.2.diff added

A hunk from another patch made it in to last one.

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.3.diff added

A couple small fixes, otherwise same as above.

comment:2 Changed 11 years ago by wstewart@…

Looks very interesting. Just to let you know, the tmdb.pl script I did that is currently in trunk has an option to grab the backdrop which could be used for the banner or fanart. Would be cool if you could use this grabber to automatically populate the database field.

Changed 11 years ago by robert.mcnamara@…

Attachment: MV-fanartdownloader.diff added

Supplement patch to add fanart downloads

comment:3 Changed 11 years ago by robert.mcnamara@…

Latest patch adds fanart downloads using the TMDB script-- a word of caution-- this is NOT the way things are going to end up working the supplemental patch is *only* for purposes of testing the fanart capabilities, and is applied on top of the MVnewmeta.3.diff patch. Then you (I) add fanart to a screen with something like:

        <imagetype name="fanart">
            <area>0,0,1280,720</area>
            <filename>gallery_fanart.jpg</filename>
        </imagetype>

Where gallery_fanart.jpg is a fallback file when no cover fanart is available.

Once more, this latest patch is ONLY for quickly adding some fanart to the DB and testing the above patch, and the fanart downloads are probably not going to be ultimately handled this way. Back up your DB, you have been warned!

Changed 11 years ago by robert.mcnamara@…

Attachment: MV-fanartdownloader.2.diff added

Fix to keep Fanart from Overwriting Coverfile, supercedes previous.

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.4.diff added

Adds file selector popup for screenshots, banner, fanart

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.5.diff added

Accounts for changes to file browser, minor fixes

comment:4 Changed 11 years ago by robert.mcnamara@…

Just a quick example of how #6158 and #6159 work together to create some neat effects-- there's about 40 lines of code not yet submitted to create the second effect, but you get the idea. In the "Watch Recordings" example, the images are all being guessed (from the contents of the fanart/banner/coverart dirs) in real time-- 100% success rate so far given just a *little* effort in naming them.

http://www.fecitfacta.com/myth-theme-screencap2.ogg http://www.fecitfacta.com/PBBFanartBannerCoverart.ogg

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.6.diff added

removes one inadvertantly added hunk

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.7.diff added

Improves a few variable names

Changed 11 years ago by robert.mcnamara@…

Attachment: MV-fanartdownloader.3.diff added

Update to the Fanart Downloader (supplemental, optional patch)

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.8.diff added

updates settings table values to be mythvideo.VALUE for consistency

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.9.diff added

Accounts for MythVideo? SG changes

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.10.diff added

Ports patch to use Storage Groups

comment:5 Changed 11 years ago by robert.mcnamara@…

Newest and hopefully final version of the patch. Adds storage group support for fanart, screenshots, banners, and coverart. Corrects a few little housekeeping things. The MythUIFileBrowser will need some modification to allow Storage-group'ed files to be selected. Currently the file browser for these files will only work if they use the local (non storage group) setting.

Changed 11 years ago by robert.mcnamara@…

Attachment: MVnewmeta.11.diff added

bugfix patch

comment:6 Changed 11 years ago by robert.mcnamara@…

Patch allows for better fallback from Storage Groups to local dirs-- now if the video itself is designated as in a storage group, but one of the pieces of metadata is local, everything will still work nicely.

comment:7 Changed 11 years ago by Anduin Withers

Resolution: fixed
Status: newclosed

(In [20139]) Closes #6159

Patch from Robert McNamara?

  • Adds screenshot, fanart, and banner fields and other supporting UI.

Mine

  • renamed several getters/setters

Changed 11 years ago by robert.mcnamara@…

Attachment: fanart-download.final.diff added

Fix for IsHostSet?() breakage, and updated fanart downloader

comment:8 Changed 11 years ago by Anduin Withers

(In [20140]) References #6159

Fix Metadata::IsHostSet?() bug I introduced in [20139] (spotted by Robert McNamara?).

Patch from Robert McNamara? to add fan art download stub.

Note: See TracTickets for help on using tickets.