Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#6161 closed patch (wontfix)

Settings code cleanup

Reported by: Matthew Wire <devel@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: MythTV - General Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Remove code duplication within mythdb. Merge almost identical GetSetting? and GetSettingOnHost? code and add wrapper method for GetGlobalSetting? using the same code.
Add doxygen comments for most methods.
Add wrapper for SaveGlobalSetting?.

Mythshutdown patch converts mythshutdown to use functions from mythdb rather than it's own copies.

Danielk was concerned about destabilising a core method, which I do understand. However, I have been running this code for six months now without issue and reducing the number of copies of the GetSettings? code from 3 to 1 can only aid stability in the future.

Versions of these patches were originally posted to #3910

See http://www.gossamer-threads.com/lists/mythtv/dev/366009 for more information

Attachments (3)

00-6161-mythdb-dbsettings-cleanup.patch (14.7 KB) - added by Matthew Wire <devel@…> 11 years ago.
01-6161-mythshutdown-mythdb.patch (3.9 KB) - added by Matthew Wire <devel@…> 11 years ago.
00-6161-mythdb-dbsettings-cleanup.2.patch (14.7 KB) - added by Matthew Wire <devel@…> 11 years ago.
Refresh again

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by Matthew Wire <devel@…>

Changed 11 years ago by Matthew Wire <devel@…>

Changed 11 years ago by Matthew Wire <devel@…>

Refresh again

comment:1 Changed 10 years ago by danielk

Resolution: wontfix
Status: newclosed

MythTV settings code has been since these patches.

comment:2 Changed 10 years ago by danielk

MythTV settings code has been refactored since these patches.

Note: See TracTickets for help on using tickets.