Opened 15 years ago
Closed 14 years ago
Last modified 14 years ago
#6161 closed patch (wontfix)
Settings code cleanup
| Reported by: | Owned by: | Isaac Richards | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - General | Version: | head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Remove code duplication within mythdb. Merge almost identical GetSetting? and GetSettingOnHost? code and add wrapper method for GetGlobalSetting? using the same code.
Add doxygen comments for most methods.
Add wrapper for SaveGlobalSetting?.
Mythshutdown patch converts mythshutdown to use functions from mythdb rather than it's own copies.
Danielk was concerned about destabilising a core method, which I do understand. However, I have been running this code for six months now without issue and reducing the number of copies of the GetSettings? code from 3 to 1 can only aid stability in the future.
Versions of these patches were originally posted to #3910
See http://www.gossamer-threads.com/lists/mythtv/dev/366009 for more information
Attachments (3)
Change History (5)
Changed 15 years ago by
| Attachment: | 00-6161-mythdb-dbsettings-cleanup.patch added |
|---|
Changed 15 years ago by
| Attachment: | 01-6161-mythshutdown-mythdb.patch added |
|---|
Changed 15 years ago by
| Attachment: | 00-6161-mythdb-dbsettings-cleanup.2.patch added |
|---|
comment:1 Changed 14 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
MythTV settings code has been since these patches.
Refresh again