Opened 15 years ago
Closed 15 years ago
#6169 closed patch (fixed)
Fix for PosMapFromEnc()
| Reported by: | Shane Shrybman | Owned by: | Shane Shrybman |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.22 |
| Component: | MythTV - Video Playback | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
The PosMap? is being retrieved from the encoder but it is not appended to the decoder's PosMap?.
The biggest symptom of this is that the frontend can fall back to ffmpeg seeking during livetv or while watching an in progress recording if it attempted to seek past the end of the decoder's position map.
The patch also removes the setting of positionMapType and keyframedist from PosMapFromEnc?(). This doesn't seem to be needed and is incorrect for the playback of nuv's. Added a comment that PosMapFromDb?() must be called first to ensure these are set correctly.
Attachments (1)
Change History (3)
Changed 15 years ago by
| Attachment: | fix_PosMapFromEnc.diff added |
|---|
comment:1 Changed 15 years ago by
| Owner: | changed from Isaac Richards to Shane Shrybman |
|---|---|
| Status: | new → assigned |
comment:2 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
(In [20191]) Closes #6169 Fixes retrieving the position map from the encoder.
Removes the setting of positionMapType and keyframedist from PosMapFromEnc?(..). Nuppeldecoder still uses MARK_KEYFRAME so the use of MARK_GOP_BYFRAME was a problem for nuv files. refs. #6170
PosMapFromDb?(..) must now be called first in order to have position map type and keyframedist set correctly.
Added a safety check to ensure keyframedist has been set before using it. refs. #6285