Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6664 closed enhancement (fixed)

EIT fixup for UK DVB-T/S to extract sign language information

Reported by: Nick Morrott <knowledgejunkie <at> gmail <dot> com> Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.22
Component: MythTV - EIT Version: head
Severity: medium Keywords: eit uk deaf signing sign language
Cc: Ticket locked: no

Description

The attached patches should correctly set the subtitle status of programmes having in-vision deaf signing broadcast over DVB-T/S in the UK, based on the EIT data.

My previous deaf signing patches are on tickets #4122 and #4125.

I have gone to the effort of including a patch for 0.21-fixes in the hope it can be applied (it is very trivial and has a definite benefit).

I will raise a related ticket that will add sign language specific rule clauses for the Custom Record and Power Priority screens which should round things out.

Attachments (2)

6664-eit-set-deaf-signing-status-trunk.diff (1.7 KB) - added by Nick Morrott <knowledgejunkie <at> gmail <dot> com> 10 years ago.
Deaf signing EIT status for trunk
6664-eit-set-deaf-signing-status-0-21-fixes.diff (1.6 KB) - added by Nick Morrott <knowledgejunkie <at> gmail <dot> com> 10 years ago.
Deaf signing EIT status for 0.21-fixes

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Nick Morrott <knowledgejunkie <at> gmail <dot> com>

Deaf signing EIT status for trunk

Changed 10 years ago by Nick Morrott <knowledgejunkie <at> gmail <dot> com>

Deaf signing EIT status for 0.21-fixes

comment:1 Changed 10 years ago by Stuart Auchterlonie

Milestone: unknown0.22
Status: newaccepted

Nick,

See #2201, i'd like to implement the sign language modifier as a priority modifier. HD is already done this way, and that mechanism can be extended to support Signed showings.

Stuart

comment:2 Changed 10 years ago by Stuart Auchterlonie

Status: acceptedstarted

I'm doing this slightly differently to the patch by fixing the currently handling of these items (m_ukCC regexp)

This will additionally pick out all the different types signalled AD - Audio Described S - Subtitles SL - Sign Language W - Widescreen

Stuart

comment:3 Changed 10 years ago by Stuart Auchterlonie

(In [20766]) Refs #6664. Whitespace only change first.

comment:4 Changed 10 years ago by Stuart Auchterlonie

(In [20768]) Refs #6664. UK EIT fixup. Adds handling of AD, S, SL and W tags in EIT data.

Thanks to Nick for doing a patch. I didn't use it in the end, rather I fixed the existing m_ukCC regexp to properly pull out the items of interet and apply them to the program data.

Been meaning to get this done for ages, and this ticket spurred me on to sort it out.

comment:5 Changed 10 years ago by Stuart Auchterlonie

Resolution: fixed
Status: startedclosed

(In [20769]) Fixes #6664. Backports [20768] to 0.21-fixes.

comment:6 Changed 10 years ago by J.Pilk@…

Thanks to both Nick and Stuart for this. I look forward to knowing when to expect what services - if the tags are correctly entered at source!

Note: See TracTickets for help on using tickets.