Opened 10 years ago

Closed 10 years ago

#6749 closed defect (fixed)

Invalid audio streams caused by changset 20971

Reported by: Matthias "mortalmatt" Dahl <devel@…> Owned by: Janne Grunau
Priority: minor Milestone: 0.22
Component: MythTV - Video Playback Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Changeset 20971 causes invalid audio streams to appear along side valid ones. Reverting 20971 fixes the problem.

The problem seems to be that the decision if a stream is an audio stream or not, is made upon the existence of a language description which leads to some streams wrongfully labeled as audio. The following patch adds a proper check if the stream is indeed an audio stream or not. This fixes the problem and so far hasn't caused any new ones.

Hope that helps...

Attachments (2)

fix-wrong-audio-streams (1.6 KB) - added by Matthias "mortalmatt" Dahl <devel@…> 10 years ago.
fix-wrong-audio-streams.2 (1.7 KB) - added by Matthias "mortalmatt" Dahl <devel@…> 10 years ago.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Matthias "mortalmatt" Dahl <devel@…>

Attachment: fix-wrong-audio-streams added

Changed 10 years ago by Matthias "mortalmatt" Dahl <devel@…>

Attachment: fix-wrong-audio-streams.2 added

comment:1 Changed 10 years ago by anonymous

Forgot to remove one comment line, otherwise identical. Please remove the first patch as I am not allowed to do it myself. Thanks.

comment:2 Changed 10 years ago by stuartm

Component: MythTV - GeneralMythTV - Video Playback
Milestone: unknown0.22
Owner: changed from Isaac Richards to Janne Grunau
Status: newassigned

comment:3 Changed 10 years ago by otto at kolsi dot fi

[20971] (or something else between [20970]-[20975]) broke the audio streams and DVB subtitles for me. mortalmatt's patch fixes the audio issue, but the DVB subtitles are still missing.

comment:4 Changed 10 years ago by Janne Grunau

Resolution: fixed
Status: assignedclosed

(In [20978]) fix audio/subtitle detection in the mpegts demuxer, fixes #6749

comment:5 Changed 10 years ago by anonymous

Janne, unfortunately [20978] does not fix the issue. Things are still unchanged.

comment:6 Changed 10 years ago by Janne Grunau

Resolution: fixed
Status: closednew

I need a small sample, or at least the PMT of the recording.

comment:7 Changed 10 years ago by anonymous

Janne, please close. I found a stale libmythavformat* from a just a few revisions back (remainings from when I was doing debugging) which portage didn't consider to overwrite for some reason. So, everything is detecte fine. On the bright side: After reading through mpegts.c the last hour, at least I understand it a lot more.

I apologize for any inconvenience caused...

comment:8 Changed 10 years ago by Dibblah

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.