Opened 15 years ago
Closed 15 years ago
Last modified 15 years ago
#7322 closed defect (fixed)
JumpPoints dont work in mythvideo gallery view or during gallery view playback
| Reported by: | Owned by: | Anduin Withers | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.23 |
| Component: | Plugin - MythVideo | Version: | 0.22-fixes |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
to reproduce switch to gallery view then go into a few folders and press a jump point keybinding i.e main menu or recordings
it will just move you up one directory this also happens during video playback if using gallery view.
can be reproduced in trunk and release-0-22-fixes
Attachments (1)
Change History (10)
Changed 15 years ago by
| Attachment: | mythvideo_jumppoints.patch added |
|---|
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
wow thanks heaps Jim Stichnoth I applied it to 22-fixes works cleanly and really well you made my day been waiting for someone to fix this .
comment:3 Changed 15 years ago by
| Component: | MythTV - General → Plugin - MythVideo |
|---|---|
| Milestone: | unknown → 0.23 |
| Owner: | changed from Isaac Richards to Anduin Withers |
| Version: | unknown → 0.22-fixes |
comment:4 Changed 15 years ago by
Sorry -- in my excitement and haste I forgot to untabify the patch. I won't bother resubmitting since it's only a one-line patch.
I got to learn how JumpPoints? are implemented. Apparently an escape-key event is synthesized and continually propagated until the main menu is reached, and then the jump point is executed. This requires cooperation from the escape-key handler of each component/screen, which is supposed to check whether we are trying to exit out to the main menu. Without this patch, MythVideo? isn't doing that check, so if you're at a screen that takes more than one escape key to exit out of MythVideo?, JumpPoint? processing gets messed up.
comment:5 Changed 15 years ago by
The implementation of jumppoints could be vastly improved, generating keypresses is sub-optimal. With mythui we can instead just iterate down the stacks closing screens until we reach the main menu.
comment:6 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [23085]) Fixes #7322. Allow MythVideo? views with a directory-style hierarchy to respond properly to JumpPoint? actions. Patch is a workaround until JumpPoints? are reworked in the future. Thanks to Jim Stichnoth for the patch.
Such a minuscule patch, such a huge delta WAF...