Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#7448 closed defect (fixed)
Video Override modes never match Video
Reported by: | reidjr_at_lineone_net | Owned by: | JYA |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | MythTV - Video Playback | Version: | 0.22rc1 |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
[Been scratching my head trying to get override modes to work, to match PAL/NTSC playback framerate and resolution.]
The override modes (Settings -> Appearance -> Video modes) no longer work in 0.22-fixes.
in DisplayRes?.cpp
Upon initialization, a key is generated for each override mode using :
uint key = DisplayResScreen::CalcKey(iw, ih, irate);
Upon Video playback, a key is generated based on Video dimensions and framerate
uint key = DisplayResScreen::CalcKey(iwidth, iheight, frate);
This key is checked against they keys for each override mode. If they match, then the associated output framesize and rate should be used rather than the default.
However as the override modes have no framerate, irate is always 0, and even when the frame dimensions match the keys never match ( unless the Video reports a 0 frate).
Attached is a trivial patch to remove frate from the key generated for the Video, (also set to 0) , allowing matching keys to be generated.
Attachments (2)
Change History (6)
Changed 14 years ago by
Attachment: | overridemode.patch added |
---|
comment:2 Changed 14 years ago by
Can you please re-test with (an unpatched) 0.23-fixes. There have been some changes that may have fixed this. Thanks.
comment:4 Changed 14 years ago by
Owner: | changed from Janne Grunau to JYA |
---|
that patch will remove the ability of myth to automatically set the framerate according to the video being played.
edit your setting, and change the framerate in the override mode to "any".
overrides mode do have framerate, 0 (displayed as "any") means 'match the rate automatically'.
Changed 14 years ago by
Attachment: | videomode.log added |
---|
720x480 video no tmatching 720x480 override mode
Trivial patch to allow matching override modes