ThreadedFileWriter::Open failing to check return value for pthread_create

[Robin Hill <myth@…>]

I've been having problems with updating MythVideo? metadata (see ticket #7450), and decided to dig further into this. I eventually tracked it down to the pthread_create call in ThreadedFileWriter::Open silently failing (in this case, with 'Resource temporarily unavailable'). The system then ends up in a loop when it attempts to flush the data, but has no writer/syncer to do it.

MythTV Version : 22733M
MythTV Branch : branches/release-0-22-fixes
Network Protocol : 50
Library API : 0.22.20091023-1
QT Version : 4.5.2
Options compiled in:

linux release using_oss using_alsa using_backend using_dvb using_frontend using_iptv using_libfftw3 using_lirc using_mheg using_opengl_video using_opengl_vsync using_qtwebkit using_x11 using_xrandr using_xv using_bindings_perl using_bindings_python using_opengl using_ffmpeg_threads using_live using_mheg

[Stuart Auchterlonie]

This problem also applies to #6330 (lockless ThreadedFileWriter?)

[cpinkham]

(In [26165]) Check the output of pthread_create in ThreadedFileWriter::Open() so that we abort a file write if we can't spawn the appropriate writer and syncer threads.

Closes #7501.