Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7680 closed patch (fixed)

Use image/jpeg enclosures as thumbnails in MythNews

Reported by: otto at kolsi dot fi Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: Plugin - MythNews Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Attached patch adds support for jpeg images in <enclosure> tags so that these are treated like thumbnails.

Modification to mythnews.cpp fixes issue where previous thumbnail image was shown for current news article when current article does not have thumbnail. I noticed this while working with the enclosure improvement. Even if that part would not be applied, this fix probably should be.

Following feed can be used to test both enclosures and the case where (most of the time) not every article/item has a thumbnail/enclosure: http://yle.fi/uutiset/rss/news.rss

Without this patch, those jpeg image enclosures are treated as downloadable media. They are downloaded (I think, haven't verified) when you select that article but then nothing is shown. What's more problematic is that this download behaviour blocks the feature where you can open the article to MythBrowser?. So without this patch, you cannot open the articles (with enclosures) in above feed.

Attachments (1)

mnews-enclosure-image.patch (1.8 KB) - added by otto at kolsi dot fi 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by otto at kolsi dot fi

Attachment: mnews-enclosure-image.patch added

comment:1 Changed 11 years ago by paulh

Resolution: fixed
Status: newclosed

(In [22990]) Use image/jpeg enclosures as thumbnails in MythNews? instead of trying to play them. Patch from Otto. Fixes #7680.

comment:2 Changed 11 years ago by paulh

(In [22991]) Backport [22990] from trunk

Use image/jpeg enclosures as thumbnails in MythNews? instead of trying to play them. Patch from Otto. Fixes #7680.

Note: See TracTickets for help on using tickets.