Opened 10 years ago

Closed 10 years ago

#7791 closed patch (fixed)

mythgallery mark/unmark single/all files

Reported by: Robert S Owned by: paulh
Priority: minor Milestone: 0.23
Component: Plugin - MythGallery Version: head
Severity: low Keywords: mythgallery mark marking single image
Cc: Ticket locked: no

Description

This patch allows to user to mark or unmark either one single file or all files at once. This was not available in the current mythgallery.

The mythtv-... patch adds a new required method to the mythtv mythuibuttonlist widget. The second patch adds the functionality to mythgallery.

The patches are against trunk version 22906.

Attachments (4)

mythtv-buttonlist-marking.patch (919 bytes) - added by Robert S 10 years ago.
mythgallery-buttonlist-marking.patch (8.9 KB) - added by Robert S 10 years ago.
mythgallery-buttonlist-marking2.patch (2.0 KB) - added by Robert S 10 years ago.
mythgallery-buttonlist-marking2-exif-required.patch (2.0 KB) - added by Robert S 10 years ago.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Robert S

Changed 10 years ago by Robert S

comment:1 in reply to:  description Changed 10 years ago by anonymous

Just for information: Marking single files is possible via the MARK button, but it was not available as an menu entry which I think should be available.

Robert S

comment:2 Changed 10 years ago by stuartm

Status: newinfoneeded_new

Robert, Thank you for taking the time to submit your patches.

No for the feedback. It's not acceptable to replace the event driven menu with slots, the latter is deprecated because it's considered less safe. As implemented in MythGallery it might be a little untidy but that's no reason to make a change that is unrelated to your proposed feature.

I'm also unsold on the need for the change to MythUIButtonList. As supplied it's a sure fire recipe for segfaults since at no point do you check that pos is actually valid (Mark called on an empty list etc).

MythUIButtonListItem *item = m_imageList->GetItemCurrent();
if (!item)
    return;
item->SetChecked(MythUIButtonListItem::FullChecked);

Achieves the same thing with no changes to MythUIButtonList and consistent with the usage of MythUIButtonList everywhere else.

If you can resubmit the patches without the unnecessary changes then we can take another look.

comment:3 in reply to:  2 Changed 10 years ago by Robert S

Hi Stuart,

thanks for the information. I have changed the patch accordingly. No need to change the mythuibuttonlist anymore and there are no more slots.

The ...-exif-required.patch file is only if someone has already applied Ticket 7376.

Robert S

Changed 10 years ago by Robert S

Changed 10 years ago by Robert S

comment:4 Changed 10 years ago by paulh

Milestone: 0.220.23
Status: infoneeded_newnew

comment:5 Changed 10 years ago by paulh

Owner: changed from Isaac Richards to paulh
Status: newassigned

comment:6 Changed 10 years ago by paulh

Resolution: fixed
Status: assignedclosed

(In [23258]) Add some menu entries to mark/unmark a single image or all images in the current directory. Patch from Robert S. Closes #7791.

Note: See TracTickets for help on using tickets.