Opened 20 years ago
Closed 20 years ago
#783 closed patch (invalid)
Pausing in mythmusic doesn't work, unpausing restarts track
Reported by: | Owned by: | Isaac Richards | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythmusic | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
If you're eg. 4mins into a track and pause, all looks well. But when hit pause again, the track just restarts.
The logic for unpausing is faulty in that it only knows of the two states that the `bool isplaying
' can show. Pausing makes the outputdevice stop playing and toggles isplaying to false. But unpausing now doesn't know if we were playing and paused or if we're stopped, so it just restarts the track.
Attached patch replaces 'bool isplaying
` with a state variable that that can indicate we're paused and should resume.
Attachments (1)
Change History (5)
Changed 20 years ago by
Attachment: | musicpause.patch added |
---|
comment:1 Changed 20 years ago by
Type: | defect → patch |
---|
comment:2 Changed 20 years ago by
Version: | → head |
---|
comment:4 Changed 20 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
You're right and I suck. I 'discovered' this while I had another patch applied and didn't verify against a clean tree...
doh.
patch to fix pausing