Opened 15 years ago

Closed 15 years ago

#783 closed patch (invalid)

Pausing in mythmusic doesn't work, unpausing restarts track

Reported by: eskil <myth@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If you're eg. 4mins into a track and pause, all looks well. But when hit pause again, the track just restarts.

The logic for unpausing is faulty in that it only knows of the two states that the `bool isplaying' can show. Pausing makes the outputdevice stop playing and toggles isplaying to false. But unpausing now doesn't know if we were playing and paused or if we're stopped, so it just restarts the track.

Attached patch replaces 'bool isplaying` with a state variable that that can indicate we're paused and should resume.

Attachments (1)

musicpause.patch​ (2.8 KB) - added by eskil <myth@…> 15 years ago.
patch to fix pausing

Download all attachments as: .zip

Change History (5)

Changed 15 years ago by eskil <myth@…>

Attachment: musicpause.patch​ added

patch to fix pausing

comment:1 Changed 15 years ago by anonymous

Type: defect → patch

comment:2 Changed 15 years ago by anonymous

Version: → head

comment:3 Changed 15 years ago by paulh

Pausing seems to work fine for me?

comment:4 Changed 15 years ago by eskil <myth@…>

Resolution: → invalid
Status: new → closed

You're right and I suck. I 'discovered' this while I had another patch applied and didn't verify against a clean tree...

doh.

Note: See TracTickets for help on using tickets.