Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#7844 closed Patch - Bug Fix (fixed)

Fix mythsocketthread log spam for non-pipe select (windows)

Reported by: Jeff Lu <jll544@…> Owned by: beirdo
Priority: minor Milestone: 0.25
Component: Ports - Windows Version: Master Head
Severity: low Keywords: win32 socket
Cc: Ticket locked: no

Description

Attached patch fixes a nuisance bug that generates continuous "select returned error" messages when VB_SOCKET logging is turned on. fd_set needs to be reset between calls to select(), so the "while (!rval)" loop and redundant wait need to go.

Attachments (1)

7844-mythsocketthread.patch (934 bytes) - added by Jeff Lu <jll544@…> 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Jeff Lu <jll544@…>

Attachment: 7844-mythsocketthread.patch added

comment:1 Changed 9 years ago by robertm

Component: MythTV - GeneralPorts - Windows
Owner: changed from Isaac Richards to Nigel

comment:2 Changed 9 years ago by robertm

Owner: changed from Nigel to markk
Status: newassigned

comment:3 Changed 9 years ago by markk

Milestone: unknown0.25
Status: assignedaccepted

comment:4 Changed 8 years ago by stuartm

Type: patchPatch - Bug Fix
Version: headTrunk Head

This one seems pretty simple to review for anyone familiar with the socket code. I'm not sure it's specific to Windows either.

comment:5 Changed 8 years ago by Github

Resolution: fixed
Status: acceptedclosed

Fix spamming non-pipe select

It is necessary to reset the contents of rfds and efds both every time before running select. As this was missing from the loop, unexpected breakage occurred. Also, don't say we've received data if the rval <= 0 (i.e. no results or an error).

This is inspired by the patch in #7844. Closes #7844.

Branch: master Changeset: ea364b3b2be961bb0949381a0c1647ab9b35763e

comment:6 Changed 8 years ago by beirdo

Owner: changed from markk to beirdo
Note: See TracTickets for help on using tickets.