Opened 15 years ago
Closed 15 years ago
#7961 closed patch (fixed)
Fix handling of streams without PTS values in every frame
Reported by: | Owned by: | Janne Grunau | |
---|---|---|---|
Priority: | critical | Milestone: | 0.23 |
Component: | MythTV - Video Playback | Version: | 0.22-fixes |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
The current handling of streams without pts values in every frame is broken, frames without a stored pts value will have a temppts value of 0, not below 0 which the current check looks for.
Another problem with the current implementation is that it uses time_base when interpolating the pts value, on the channels I have seen that does not set the pts value, the time_base value is not a 1:1 mapping to the frame rate (50fps vs a time_base of 90,000) so this patch changes this behaviour to use curstream->r_frame_rate instead.
Attachments (1)
Change History (7)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
Component: | MythTV - General → MythTV - Video Playback |
---|---|
Milestone: | unknown → 0.23 |
Owner: | changed from Isaac Richards to Janne Grunau |
Version: | unknown → 0.22-fixes |
comment:3 Changed 15 years ago by
Priority: | minor → critical |
---|
comment:4 Changed 15 years ago by
Peter, please provide a short sample which demonstrates your problem. You can use something like dd if=video.mpg of=video_small.mpg bs=1024 count=50000 to generate a 50MB file and upload to filebin.ca.
comment:6 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [23612]) Correct the video timestamp fixup code by making the following changes:
- Perform fixup when PTS is not available which is indicated by temppts == 0.
- Calculate temppts using fps instead of context->time_base. The prior calculation was actually wrong since it also needed to be multiplied by context->ticks_per_frame. Using fps also allows us to be consistent with normalized_fps().
This commit is a slight modification of the provided patch.
Thanks to Peter Alm for the patch and sample.
Fixes #7961.
Forgot to set a few fields:
Version should be 0.22-fixes Component should be MythTV - Video Playback