Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#8124 closed defect (fixed)

Themestring.h updates in r23643 appears to be wrong

Reported by: Kenni Lund <kenni@…> Owned by: Isaac Richards
Priority: critical Milestone: 0.23
Component: MythTV - General Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no


The update of themestrings in r23643 appears to be wrong. As far as I can see, mythfrontend now includes around 1010 strings from the plugins. Strings like "Humidity:" (from mythweather) or "Scan for Games" (mythgames) are now part of the mythfrontend translation...

It also seems like unreleated *.xml files are included. I noticed that strings from mythweather/scripts/us_nws/maps.xml was included, which includes 411 names. I don't know if this was done intentionally, but it seems kinda waste of time to translate 400 names like "France Satellite", "Germany Satellite", "West U.S Travel Weather", etc.

Change History (3)

comment:1 Changed 11 years ago by Nicolas Riendeau <knight@…>


The script committed in changeset 23642 actually goes back one directory too many and processes the entire MythTV structure including the plugins (which is the reason why you see stuff from MythWeather? MythGames?, etc...).

As for the XML files used by the US NWS parser they should not, as I had told you in a (private) email a few months ago, be included. The themestringtool processes these like they were themes because they are XML files and contain <description> fields.

By the way, it should be noted that the script in changeset 23642 should not be run in a directory structure where you have uncommitted (or not yet put in a .diff file) stuff because it removes files to get them out of the way and the easiest way to get rid of the the US NWS XML files would be to remove them as well before running the themestringtool so it would remove even more stuff than what is currently removed.

It might also be a good idea to make a temporary symlink to the other theme directories (that were added in changeset 23649) so that it would make them at the same time and avoid the duplicates created by running them in two pass and merging them after.

Have a nice day,


comment:2 Changed 11 years ago by danielk

Resolution: fixed
Status: newclosed

(In [23651]) Fixes #8124. Removes execution bit on mythplugins dir while themestrings runs on themes myththemes and mythtv/themes directories so as not to pick up the plugin's theme strings in main i18n.

comment:3 Changed 11 years ago by danielk

(In [23652]) Refs #8124. Exclude mythweather grabber strings from i18n. Ideally these would be translated into at least Spanish and French but I we'd probably need code changes for that first.

Note: See TracTickets for help on using tickets.