Opened 14 years ago
Closed 14 years ago
#8153 closed patch (fixed)
Enable external subtitles in OSD menu
| Reported by: | Owned by: | Isaac Richards | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.24 |
| Component: | MythTV - General | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
External subtitle files, such as .srt files, can be toggled during playback with the 't' key, but the OSD menu entry for controlling subtitle display is suppressed. This patch allows the entry to show up in the OSD menu and do the right thing.
Attachments (2)
Change History (5)
Changed 14 years ago by
| Attachment: | external_subtitle_menu.patch added |
|---|
Changed 14 years ago by
| Attachment: | external_subtitle_menu_v2.patch added |
|---|
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
This patch seems unnecessary after the libmythui-osd merge. Please close the ticket.
comment:3 Changed 14 years ago by
| Milestone: | unknown → 0.24 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
| Version: | unknown → Trunk Head |
Fixed by recent changes (likely in the libmythui-osd branch and merged to trunk).
Thanks for the update, Jim (not to mention the patch).
Note: See
TracTickets for help on using
tickets.
Updated the patch to be more complete. The original patch only adds the "Toggle On/Off?" entry to the OSD for text subtitles. This patch adds the checkbox line to the OSD which indicates whether text subtitles are on or off, and handles the SELECT action for that OSD entry. It also does something reasonable for NEXTSUBTITLE and PREVSUBTITLE.
The original handling of text subtitles is a little odd. They are basically handled as a special case of regular DVD-style subtitles instead of as their own separate track type. This patch continues with that model, but someone might want to consider changing that model.