Opened 18 years ago
Closed 18 years ago
#823 closed defect (fixed)
Patch: Fix compile issue on GCC-4.1.0 x86_64
Reported by: | Owned by: | Isaac Richards | |
---|---|---|---|
Priority: | major | Milestone: | unknown |
Component: | mythtv | Version: | |
Severity: | high | Keywords: | |
Cc: | Ticket locked: | no |
Description
datadirect.h contains:
bool DataDirectProcessor::getNextSuggestedTime(void);
which should be
bool getNextSuggestedTime(void);
GCC 4.1.x is more strict about defining member methods for a class. It should not contain the extra "DataDirectProcessor::".
Patch is:
Index: libs/libmythtv/datadirect.h =================================================================== --- libs/libmythtv/datadirect.h (revision 8300) +++ libs/libmythtv/datadirect.h (working copy) @@ -268,7 +268,7 @@
void setInputFile(const QString &filename);
- bool DataDirectProcessor::getNextSuggestedTime(void);
+ bool getNextSuggestedTime(void);
QValueList<DataDirectStation?> stations; QValueList<DataDirectLineup?> lineups;
Change History (3)
comment:1 Changed 18 years ago by
comment:2 Changed 18 years ago by
Additionally for honoring ANSI C conventions, the following patch has to be made to compile with GCC-4.1.0
Index: libs/libmythtv/avformatdecoder.cpp =================================================================== --- libs/libmythtv/avformatdecoder.cpp (revision 8301) +++ libs/libmythtv/avformatdecoder.cpp (working copy) @@ -55,6 +55,8 @@
void release_avf_buffer_xvmc(struct AVCodecContext *c, AVFrame *pic); void render_slice_xvmc(struct AVCodecContext *s, const AVFrame *src,
int offset[4], int y, int type, int height);
+void decode_cc_dvd(struct AVCodecContext *s, const uint8_t *buf, int buf_size); +void decode_cc_atsc(struct AVCodecContext *s, const uint8_t *buf, int buf_size);
static void align_dimensions(AVCodecContext *avctx, uint &width, uint &height) {
Oopsie, trac seems to like to interpret ticket contents. So this is the patch again in a code block: