Opened 9 years ago

Closed 3 years ago

#8251 closed Patch - Bug Fix (fixed)

EIT Scanner disregards input groups, causes undefined behavior

Reported by: robertm Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.28
Component: MythTV - EIT Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hybrid tuners analog and digital sides share a tuner, and thus are properly configured as members of the same input group. The EIT scanner disregards input groups and will kick off when the analog side is in use, putting the hardware in an undefined state and causing tuning failures and other potential Bad Things (tm), which will vary by driver.

The EIT scanner should account for the other members of the input group.

Attachments (2)

8251-v1.patch (1.4 KB) - added by danielk 7 years ago.
Possible fix.
8251-v2.diff (1.6 KB) - added by lomion@… 7 years ago.
Patch based on 0.25-fixes

Download all attachments as: .zip

Change History (16)

comment:1 Changed 9 years ago by Stuart Auchterlonie

Milestone: unknown0.24

comment:2 Changed 9 years ago by robertm

Status: newassigned

comment:3 Changed 9 years ago by stuartm

Milestone: 0.240.25
Priority: minorcritical

I'm bumping the priority but moving this to 0.25 since no-one with an interest in this area of the code has the time to work on a fix for 0.24. This is clearly a serious bug all the same.

comment:4 Changed 8 years ago by herbert@…

I think my installation runs into this problem each day - I will take a closer look the next days.

Changed 7 years ago by danielk

Attachment: 8251-v1.patch added

Possible fix.

comment:5 Changed 7 years ago by danielk

Milestone: 0.250.26
Priority: criticalminor
Type: defectPatch - Bug Fix

I've downgraded this from critical to minor. It doesn't affect many people and the workaround is simply not to enable eit scanning on any dtv recorder also used for it's analog side.

I've attached a patch which should automatically disable active EIT scanning when an input is shared with an analog recorder. It is untested, but should provide a good start for anyone working on this. The main concern is that it has a bad effect on a DVB-S card with DiSEqC inputs. Since this does need a testing both for function and for no ill-effect on DiSEqC setups I'm moving the milestone to 0.26, but if this receives sufficient testing there is no reason it can't be put in for 0.25.

comment:6 Changed 7 years ago by Kenni Lund [kenni a kelu dot dk]

Milestone: 0.260.26.1

comment:7 Changed 7 years ago by lomion@…

I have two virtual encoders configured for my DVB-S2 card and see the same behaviour.

I have attached a modified patch which delays the EIT-Scan for 60 seconds if another card in the same input group is busy. It works for me!

Changed 7 years ago by lomion@…

Attachment: 8251-v2.diff added

Patch based on 0.25-fixes

comment:8 Changed 6 years ago by paulh

Milestone: 0.26.10.27

There is an updated patch that is reported to work

comment:9 Changed 5 years ago by Stuart Auchterlonie

Version: headMaster Head

comment:10 Changed 4 years ago by Stuart Auchterlonie

Milestone: 0.270.27.6

comment:11 Changed 4 years ago by Karl Egly

Milestone: 0.27.60.27.7

Reschedule all tickets planned for, but not solved in time for, 0.27.6 to 0.27.7.

comment:12 Changed 3 years ago by David Engel <dengel@…>

In f65ae619a5e1949b538ac20fbd17f2cb826221cf/mythtv:

Change EIT scanning to consider input groups.

Postpone scanning if another input in same input group is busy. This
is base on a patch from robertm.

Refs #8251

comment:13 Changed 3 years ago by Stuart Auchterlonie

Milestone: 0.27.70.28

comment:14 Changed 3 years ago by David Engel <dengel@…>

Resolution: fixed
Status: assignedclosed

In ff43962bbc1523996f25b9536410f37f8cb97065/mythtv:

Change EIT scanning to consider input groups.

Postpone scanning if another input in same input group is busy. This
is base on a patch from robertm.

Fixes #8251

Signed-off-by: Stuart Auchterlonie <stuarta@…>
(cherry picked from commit f65ae619a5e1949b538ac20fbd17f2cb826221cf)

Note: See TracTickets for help on using tickets.