Opened 9 years ago

Closed 8 years ago

#8318 closed enhancement (Fixed)

AvFormatDecoder::GetFrame() cleanup

Reported by: foobum <foobum@…> Owned by: Janne Grunau
Priority: minor Milestone: 0.25
Component: MythTV - General Version: head
Severity: low Keywords: AVFormatDecoder GetFrame
Cc: Ticket locked: no

Description

GetFrame() is over 1000 lines long. Attached patch splits it out into a number of new methods and tidies it up a bit. Also remove some unused member variables and a few whitespace fixes. No functional changes.

Attachments (3)

getframe.patch (73.1 KB) - added by foobum <foobum@…> 9 years ago.
getframe.2.patch (67.8 KB) - added by JYA 9 years ago.
Updated for trunk r24111 ; remove whitespace only changes
getframe.3.patch (67.7 KB) - added by JYA 9 years ago.
Updated for trunk r24131 ; remove whitespace only changes

Download all attachments as: .zip

Change History (21)

Changed 9 years ago by foobum <foobum@…>

Attachment: getframe.patch added

comment:1 Changed 9 years ago by JYA

Owner: changed from Isaac Richards to JYA
Status: newassigned

Changed 9 years ago by JYA

Attachment: getframe.2.patch added

Updated for trunk r24111 ; remove whitespace only changes

comment:2 Changed 9 years ago by Janne Grunau

(In [24125]) AVFD: remove unused variables, Refs #8318

Changed 9 years ago by JYA

Attachment: getframe.3.patch added

Updated for trunk r24131 ; remove whitespace only changes

comment:3 Changed 9 years ago by Janne Grunau

Milestone: unknown0.24
Owner: changed from JYA to Janne Grunau
Status: assignedaccepted

comment:4 Changed 9 years ago by Janne Grunau

(In [24134]) AVFD: make skipaudio and allowedquit member variables, Refs #8318

comment:5 Changed 9 years ago by Janne Grunau

(In [24135]) AVFD: factor video preprocessing out, Refs #8318

comment:6 Changed 9 years ago by Janne Grunau

(In [24138]) AVFD: factor video decoding into it's own function, Refs #8318

comment:7 Changed 9 years ago by Janne Grunau

(In [24139]) cosmetics: AVFD re-indent after video decoding refactoring, Refs #8318

comment:8 Changed 9 years ago by Janne Grunau

(In [24140]) AVFD: factor out subtitle decoding into its own function, Refs #8318

comment:9 Changed 9 years ago by Janne Grunau

(In [24141]) cosmetics: AVFD re-indent after subtitle decoding refactoring, Refs #8318

comment:10 Changed 9 years ago by Janne Grunau

(In [24142]) AVFD: move audio decoding to its own function, Refs #8318

comment:11 Changed 9 years ago by Janne Grunau

(In [24143]) cosmetics: AVFD reindent after audio decoding refactoring, Refs #8318

comment:12 Changed 9 years ago by Janne Grunau

(In [24149]) AVFD: move data packet handling code to its own function, Refs #8318

comment:13 Changed 9 years ago by Janne Grunau

(In [24150]) AVFD: push firstloop variable down to ProcessAudioPacket?, Refs #8318

comment:14 Changed 9 years ago by Janne Grunau

(In [24151]) AVFD: simplify loop handling in ProcessAudioPacket?, Refs #8318

comment:15 Changed 9 years ago by Janne Grunau

(In [24153]) AVFD: remove unneeded pts handling code from GetFrame?, Refs #8318

comment:16 Changed 9 years ago by stuartm

Milestone: 0.240.25

comment:17 Changed 9 years ago by stuartm

Milestone: 0.25

Milestone 0.25 deleted

comment:18 Changed 8 years ago by robertm

Resolution: Fixed
Status: acceptedclosed

Closing as fixed since there hasn't been any progress on this for a year (after a flurry of what may have made this "fixed").

Note: See TracTickets for help on using tickets.