Opened 10 years ago

Closed 10 years ago

#8334 closed defect (fixed)

libavcodec/mpeg12.c fails to compile on MacOS X

Reported by: anonymous Owned by: Janne Grunau
Priority: minor Milestone: 0.24
Component: Ports - OSX Version: Master Head
Severity: high Keywords:
Cc: Ticket locked: no

Description

cd libmythui/ && /usr/bin/make -f Makefile mpeg12.c: In function ‘mpeg_decode_user_data’: mpeg12.c:2315: error: ‘uint’ undeclared (first use in this function) mpeg12.c:2315: error: (Each undeclared identifier is reported only once mpeg12.c:2315: error: for each function it appears in.) mpeg12.c:2315: error: expected ‘;’ before ‘cc_count’ mpeg12.c:2316: error: expected ‘;’ before ‘cc_bits’ mpeg12.c:2317: error: expected ‘;’ before ‘cc_bytes’ mpeg12.c:2320: error: ‘cc_bytes’ undeclared (first use in this function) mpeg12.c:2326: error: ‘cc_count’ undeclared (first use in this function) make[2]: * [mpeg12.o] Error 1 make[1]: * [sub-libavcodec-make_default] Error 2 make[1]: * Waiting for unfinished jobs.... make[2]: Nothing to be done for `first'. make: * [sub-libs-make_default-ordered] Error 2 [osx-pkg] Failed system call: " /usr/bin/make -j3 " with error code 2

uint isn't defined. These variables really should be uint8_t.

Attachments (1)

mythosx.diff (794 bytes) - added by dougt@… 10 years ago.
patch to libs/libavcodec/mpeg12.c

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by dougt@…

Attachment: mythosx.diff added

patch to libs/libavcodec/mpeg12.c

comment:1 Changed 10 years ago by robertm

Status: newinfoneeded_new

This is an upstream library that a) we won't modify any more than we have locally and b) definitely compiles on OS X.

Are you doing anything exotic in attempting to build? Are you using the build script? Have you made any modifications to it? What version of OS X? What architecture?

comment:2 in reply to:  1 Changed 10 years ago by dougt@…

Replying to robertm:

This is an upstream library that a) we won't modify any more than we have locally and b) definitely compiles on OS X.

Are you doing anything exotic in attempting to build? Are you using the build script? Have you made any modifications to it? What version of OS X? What architecture?

10.6.3, xcode up to date. No local changes to the source.

I am using the osx-packager tool:

perl osx-packager.pl -plugins mythvideo,mythweather

nothing else very special.

comment:3 Changed 10 years ago by robertm

Status: infoneeded_newnew

This build failure introduced by r24059. Daniel, this patch seems fine but since it's your code you would know better.

comment:4 Changed 10 years ago by robertm

Owner: changed from Nigel to danielk
Status: newassigned

comment:5 Changed 10 years ago by Janne Grunau

Milestone: unknown0.24
Owner: changed from danielk to Janne Grunau
Status: assignedaccepted

comment:6 Changed 10 years ago by Janne Grunau

Resolution: fixed
Status: acceptedclosed

(In [24093]) replaces uint with unsigned int in libs/libav*, Fixes #8334

Note: See TracTickets for help on using tickets.