Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#8522 closed enhancement (Fixed)

Include only half the blank frames between commercial breaks

Reported by: Jim Stichnoth <stichnot@…> Owned by: mdean
Priority: minor Milestone: 0.25
Component: MythTV - Mythcommflag Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When the commercial skiplist is created, I prefer to include a blank interval between program sections (CommSkipAllBlanks?=0). Sometimes, though, a small piece of the commercial break gets included. A pretty good compromise is to include half of the blank interval. This patch adds that as a CommSkipAllBlanks? option.

Note: The patch addresses all places where the skiplist is adjusted according to the blank sections, but I have only tested the portion in BuildAllMethodsCommList?().

Attachments (3)

commflag_split_blanks.patch (10.2 KB) - added by Jim Stichnoth <stichnot@…> 4 years ago.
commflag_split_blanks_v2.patch (10.2 KB) - added by Jim Stichnoth <stichnot@…> 4 years ago.
commflag_split_blanks_v3.patch (11.4 KB) - added by Jim Stichnoth <stichnot@…> 4 years ago.

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by Jim Stichnoth <stichnot@…>

Changed 4 years ago by Jim Stichnoth <stichnot@…>

comment:1 Changed 4 years ago by Jim Stichnoth <stichnot@…>

Updated with commflag_split_blanks_v2.patch after libmythui-osd branch merge.

comment:2 Changed 4 years ago by robertm

  • Owner changed from cpinkham to mdean
  • Status changed from new to assigned

Changed 4 years ago by Jim Stichnoth <stichnot@…>

comment:3 Changed 4 years ago by Jim Stichnoth <stichnot@…>

Updated with v3 patch. Following the discussion on the dev list, this version removes the CommSkipAllBlanks? setting altogether, and always includes half the blank interval in the non-commercial segment, up to a maximum of MAX_BLANK_FRAMES frames (arbitrarily defined to be 60).

comment:4 Changed 3 years ago by mdean

  • Resolution set to Fixed
  • Status changed from assigned to closed

(In [27389]) Show half the blank frames before and after the commercial break.

This allows MythTV to better handle those shows with trailing/leading audio that extends into blank frames. Thanks to Jim S. for this patch, which simplifies configuration and gives a more sensible behavior than either of the previously-selectable behaviors.

Only new recordings/newly-commercial-flagged recordings will be affected by this change.

Closes #8522 by applying patch from Jim S.

comment:5 Changed 3 years ago by mdean

  • Milestone changed from unknown to 0.25

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.