Opened 14 years ago
Closed 13 years ago
Last modified 13 years ago
#8522 closed enhancement (Fixed)
Include only half the blank frames between commercial breaks
Reported by: | Owned by: | sphery | |
---|---|---|---|
Priority: | minor | Milestone: | 0.25 |
Component: | MythTV - Mythcommflag | Version: | Unspecified |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
When the commercial skiplist is created, I prefer to include a blank interval between program sections (CommSkipAllBlanks?=0). Sometimes, though, a small piece of the commercial break gets included. A pretty good compromise is to include half of the blank interval. This patch adds that as a CommSkipAllBlanks? option.
Note: The patch addresses all places where the skiplist is adjusted according to the blank sections, but I have only tested the portion in BuildAllMethodsCommList?().
Attachments (3)
Change History (8)
Changed 14 years ago by
Attachment: | commflag_split_blanks.patch added |
---|
Changed 14 years ago by
Attachment: | commflag_split_blanks_v2.patch added |
---|
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Owner: | changed from cpinkham to sphery |
---|---|
Status: | new → assigned |
Changed 13 years ago by
Attachment: | commflag_split_blanks_v3.patch added |
---|
comment:3 Changed 13 years ago by
Updated with v3 patch. Following the discussion on the dev list, this version removes the CommSkipAllBlanks? setting altogether, and always includes half the blank interval in the non-commercial segment, up to a maximum of MAX_BLANK_FRAMES frames (arbitrarily defined to be 60).
comment:4 Changed 13 years ago by
Resolution: | → Fixed |
---|---|
Status: | assigned → closed |
(In [27389]) Show half the blank frames before and after the commercial break.
This allows MythTV to better handle those shows with trailing/leading audio that extends into blank frames. Thanks to Jim S. for this patch, which simplifies configuration and gives a more sensible behavior than either of the previously-selectable behaviors.
Only new recordings/newly-commercial-flagged recordings will be affected by this change.
Closes #8522 by applying patch from Jim S.
comment:5 Changed 13 years ago by
Milestone: | unknown → 0.25 |
---|
Updated with commflag_split_blanks_v2.patch after libmythui-osd branch merge.