Opened 14 years ago

Closed 14 years ago

#880 closed patch (fixed)

Add maximum commercial skip for manual skipping

Reported by: mythtv@… Owned by: cpinkham
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

When skipping commercials manually, I occassionally skip too long. This happens most often when commercial flagging has missed a commercial break. This is annoying, easy to miss (until the program returns), and painful to recover from.

This patch adds a maximum commercial skip to the configuration options (default to 3600 seconds, effectively infinite).

If the skip is too long, the OSD displays "Too Long 3:34", where 3:34 is the amount it considered skipping (negative if the skip was backwards). Pressing the skip command again (within 3 seconds) will override the option and it'll skip anyway, making it relatively painless to ignore this safety.

Attachments (1)

maxskip.patch (3.2 KB) - added by mythtv@… 14 years ago.
proposed patch

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by mythtv@…

Attachment: maxskip.patch added

proposed patch

comment:1 Changed 14 years ago by danielk

Milestone: 0.20
Owner: changed from Isaac Richards to cpinkham

comment:2 Changed 14 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [9045]) Add a "Maximum Commercial Skip" setting that limits how far a manual commercial skip will skip. If the skip length would be higher than this limit, the user has to hit the SKIP key a second time within 3 seconds. This only applies to manual commercial skip, auto-skip is unaffected. The default is 1-hour, so it shouldn't affect people unless they lower this limit on the settings page. The feature works for both forward and reverse skips. Closes #880 by applying patch.

Note: See TracTickets for help on using tickets.