Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#9 closed enhancement (fixed)

Zero time lengths in MythMusic songs

Reported by: anonymous Owned by: Isaac Richards
Priority: minor Milestone: 0.19
Component: mythmusic Version: head
Severity: medium Keywords: mythmusic 0 time length fast forward
Cc: Ticket locked: no

Description

For some unknown reason to me, MythMusic thinks almost all of my songs have a time length of 0. This causes things such as fast forwarding to not work. The only fix is to clear the column for musicmetadata, but this would clear all my song ratings, which I've spent almost 2 years setting. :)

I've seen this problem for about 4 months now.

The enhancement would be to scan for problems with the currently stored music metadata when a scan is done, and fix things such as the time length for 0 time length songs.

Attachments (1)

noreadaccess.mp3.patch (382 bytes) - added by mythtv@… 14 years ago.
Patch to not add mp3 files with 0 length when not having read access

Download all attachments as: .zip

Change History (8)

comment:1 Changed 14 years ago by anonymous

Component: mythtvmythmusic

comment:2 Changed 14 years ago by anonymous

I have this problem too but clearing the songs table does not help any. My music is all mp3, various formats.

Changed 14 years ago by mythtv@…

Attachment: noreadaccess.mp3.patch added

Patch to not add mp3 files with 0 length when not having read access

comment:3 Changed 14 years ago by mythtv@…

This seems to happen when we don't have read access to a mp3 file. The attached patch avoid adding mp3 with 0 length in the database when the two calls to id3_file_open() failed.

comment:4 Changed 14 years ago by Isaac Richards

Patch makes no sense based on the problem report. If it couldn't read the file, it'd be unplayable, but the bug report says they play.

comment:5 Changed 14 years ago by mythtv@…

Ok, "noreadaccess.mp3.patch" is a bad name. Let's call it "id3_file_open.failure.patch". Now this patch MAY make sense for this problem.

  1. The two calls to id3_file_open() fail for any reason (no read access is one of them)
  2. A new Metadata instance is created with a 0 length
  3. The incomplete Metadata instance is returned to the caller which adds it the the DB

comment:6 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [7594]) Close #9. Return null on failure from MetaIOID3v2::read()

The patch broke fallback to filename based metadata, so I moved the check later, and checked for title, artist and file length before returning metadata.

comment:7 Changed 14 years ago by thomas@…

I have the same problem. It worked OK up to Myth 0.16 and stopped working after installing Myth 0.18. I don't think I have changed anything else on my system besides updating to 0.18.

Note: See TracTickets for help on using tickets.