Opened 9 years ago

Closed 6 years ago

#9197 closed Bug Report - General (Need more Info)

Danish EIT fixups are putting the description in the subtitle

Reported by: mk@… Owned by: Karl Egly
Priority: minor Milestone: 0.27
Component: MythTV - EIT Version: 0.23.1
Severity: low Keywords:
Cc: Ticket locked: no

Description

Sometimes my recorded programs contain a newline character in the subtitle.

Example:

INSERT INTO recordedprogram VALUES (1101,'2010-10-02 23:10:00','2010-10-03 01:10:00','Ingen er fuldkommen','Amerikansk komedie fra 1959.\rSugar er sangerinde i et dame-orkester i forbudstidens USA.','Hun ved ikke, at hendes to bedste veninder i orkestret i virkeligheden er mænd i forklædning, på flugt fra nogle gangstere, og Joe og Jerry har meget svært ved at bevare kvindeligheden i samværet med hende. Sugar: Marilyn Monroe. Joe: Tony Curtis. Jerry: Jack Lemmon. Manuskript: Billy Wilder og I.A.L. Diamond. Instruktion: Billy Wilder.',,'tvshow',0000,0,0,,1,0,0,0,0,0,,NULL,,,,,0,0,1,1,1,'STEREO',,'WIDESCREEN');

The \r character is not escaped by addslashes in modules/tv/tmpl/default/recorded.php resulting in a newline in the javascript text string.

If I change line 70 from:

file.subtitle = '<?php echo addslashes($show->subtitle) ?>';

Into:

file.subtitle = '<?php echo addslashes(str_replace(array("\n","\r"), ' ', $show->subtitle)) ?>';

the page work correctly again.

Change History (17)

comment:1 Changed 9 years ago by anonymous

How is your guide data sourced? XMLTV, schedules direct or EIT? It appears the description is being inserted into the wrong field and that should be fixed.

comment:2 Changed 9 years ago by anonymous

The data comes from DVB-T EIT

comment:3 Changed 9 years ago by stuartm

Component: Plugin - MythWebMythTV - EIT
Milestone: unknown0.24
Owner: changed from Rob Smith to janneg
Priority: minormajor
Status: newassigned

comment:4 Changed 9 years ago by stuartm

Summary: subtitles contain newlines breaks recorded.phpDanish EIT fixups are putting the description in the subtitle

comment:5 Changed 9 years ago by Kenni Lund [kenni a kelu dot dk]

Owner: changed from janneg to Janne Grunau

comment:6 Changed 9 years ago by stuartm

Milestone: 0.240.24.1

comment:7 Changed 8 years ago by stuartm

Milestone: 0.24.10.24.2

comment:8 Changed 8 years ago by danielk

Milestone: 0.24.20.25
Owner: changed from Janne Grunau to Stuart Auchterlonie
Priority: majorminor
Severity: mediumlow

comment:9 Changed 8 years ago by stuartm

Owner: changed from Stuart Auchterlonie to stuartm
Status: assignedaccepted
Type: defectBug Report - General

Some help on this would be appreciated from Danish users. I can remove the fixup that puts the description in the subtitle, but I don't know whether that would break some other channels.

comment:10 Changed 8 years ago by stuartm

Milestone: 0.250.26

I'm not going to get this fixed for 0.25, but I will backport to 0.25.1 when I do. Right now it looks like the Danish providers are sticking longer than subtitle length descriptions in the 'short' event descriptors.

Our EIT parser is at fault for treating these short descriptions as subtitles when they are anything but. There are other problems with treating the short even descriptor (max 255 char) as subtitle (max 128 char). The EIT spec makes no stipulation that the short event descriptor should contain an episode name, just a short description of the programme.

Fixing this means possibly breaking it for some networks which just happen to put the episode name in the subtitle field. We'd need to write proper fixups for those locations at the same time.

comment:11 Changed 8 years ago by stuartm

What I meant to say was:

Fixing this means possibly breaking it for some networks which just happen to put the episode name in the short event descriptor.

comment:12 Changed 7 years ago by Kenni Lund [kenni a kelu dot dk]

Milestone: 0.260.26.1

comment:13 Changed 6 years ago by paulh

Milestone: 0.26.10.28

comment:14 Changed 6 years ago by stuartm

Milestone: 0.280.27

comment:15 Changed 6 years ago by stuartm

Owner: changed from stuartm to Karl Egly
Status: acceptedassigned

Karl, maybe you'll have time to look at this for 0.27?

comment:16 Changed 6 years ago by Karl Egly

Can I see the output of "dvbsnoop -n 1 0x12" for such a program? From the EITFixUp::FixDK it is only applicable to the YouSee? DVB-C network (ONID 0xFE00, registered to TeleDenmark?), which does not fit to this sample being sourced from DVB-T. It appears as if the channel in question splits the program description into the short_event_descriptor and the extended_event_descriptor. If that happens on every danish DVB-T channel and they use the proper ONID 0x20D0 for danish DVB-T we can merge both in the description and leave the subtitle empty with a new fixup.

comment:17 Changed 6 years ago by Karl Egly

Resolution: Need more Info
Status: assignedclosed

We can't fix it without your support, sorry.

Note: See TracTickets for help on using tickets.