OSD delete dialog leaves playback paused after pressing Esc

[John Veness <John.Veness.mythtv@…>]

When D is pressed while playing back a recording, the playback pauses while a dialog pops up asking whether the user wishes to delete the recording. If the user presses Esc at this point, the dialog disappears but the playback stays paused, with no OSD indication of paused state. The user has to press P to resume playback.

I think (although have no easy way of testing) that this is new in 0.24, that is, I think in earlier versions, pressing Esc would resume playback after dismissing the OSD dialog. This would certainly seem the logical thing to do in the case that the user pressed D accidentally.

$ mythfrontend --version
Please attach all output as a file in bug reports.
MythTV Version : 27204
MythTV Branch : branches/release-0-24-fixes
Network Protocol : 63
Library API : 0.24.20101028-1
QT Version : 4.7.0
Options compiled in:

linux debug using_alsa using_jack using_oss using_pulse using_pulseoutput using_backend using_bindings_perl using_bindings_python using_dvb using_firewire using_frontend using_hdhomerun using_hdpvr using_iptv using_ivtv using_joystick_menu using_lirc using_mheg using_opengl_video using_opengl_vsync using_qtdbus using_qtwebkit using_v4l using_x11 using_xrandr using_xv using_xvmc using_xvmc_vld using_xvmcw using_bindings_perl using_bindings_python using_mythtranscode using_opengl using_vdpau using_ffmpeg_threads using_live using_mheg

[Kenni Lund [kenni a kelu dot dk]]

I honestly don't know if this is considered a bug or if it is one of the intended changes introduced by the new MythUI OSD, but I've noticed this behaviour as well. Mark, feel free to kill it or unassign it.

[John Veness <John.Veness.mythtv@…>]

If it is intended behaviour to stay paused after pressing Esc to dismiss the Delete dialog, then I suggest that the OSD paused indicator should appear. That way the user would know that he needs to unpause and doesn't just think it has hung.

However, I think it would be better to resume after pressing Esc.

[markk]

(In [27254]) Unpause playback when clearing the Delete Recording OSD dialog (if we paused it to show the dialog).

Refs #9228

[markk]

(In [27255]) Backport r27254 from trunk to release-0-24-fixes

Unpause playback when clearing the Delete Recording OSD dialog (if we paused it to show the dialog).

Closes #9228

[markk]

(In [27278]) Backport r27256 from trunk to release-0-24-fixes

Don't hold the OSD lock unnecessarily when processing editor keypresses.

Closes #9228