Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

#9266 closed Patch - Bug Fix (Fixed)

Aspect ratio detection in MythWeb streaming not accurate

Reported by: Daniel Osborne <daniel@…> Owned by: beirdo
Priority: minor Milestone: 0.25
Component: Plugin - MythWeb Version: 0.24-fixes
Severity: medium Keywords: flash streaming
Cc: Ticket locked: no

Description

I noticed the 0.24 release of MythTV included the ability to autodetect the aspect ratio of recordings for streaming over flash. However that functionality doesn't seem accurate to me at all. I find it's wrong for >70% of my recordings.
The only ones that seemed to work were SD.

What I would see were two different things:

1) The aspect ratio of flowplayer would be correct (typically 16:9), but the video would play at 4:3. This would leave the flowplayer borders on the sides.

2) Or both aspects would be wrong, and it would all be 4:3.

I dug in and found out the SQL queries used for getting that information would return 0 rows.

For example, in modules/stream/stream_flv.pl, the 'mark' column in the 'recordedmarkup' would be 1 on my machine, but the script was only filtering for '0'.
I'm not sure what that field is specifically (I think it's frame #/offset).

In modules/class/Program.php it using a completely different SQL statement. This particular statement wouldn't always return the right aspect (perhaps bug elsewhere in Myth when it's stored). I had a 16:9 program that stored a value of '14' (which meant 4:3) in the 'type' column of 'recordedmarkup', when it should have been '12'.

Anyway, I have a patch against the 0.24 branch which uses both SQL statements to figure out the aspect ratio. This has corrected my issue to near 100% accuracy (haven't found any recordings where this doesn't work for me yet).

This also fixes the aspect ratio for the thumbnail images in the Recordings page.

Attachments (2)

mythweb-streaming_aspect_fix.patch (4.6 KB) - added by Daniel Osborne <daniel@…> 3 years ago.
Patch to fix aspect ratio detection in MythWeb
mythweb-streaming_aspect_fix.2.patch (4.6 KB) - added by Daniel Osborne <daniel@…> 3 years ago.
Patch with correct paths.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by beirdo

  • Owner changed from kormoc to beirdo
  • Status changed from new to assigned

Patches are more useful if attached.

Changed 3 years ago by Daniel Osborne <daniel@…>

Patch to fix aspect ratio detection in MythWeb

comment:2 Changed 3 years ago by Daniel Osborne <daniel@…>

Wow that was fast! I didn't have time to finish attaching the patch before I got a response. :-)

Changed 3 years ago by Daniel Osborne <daniel@…>

Patch with correct paths.

comment:3 Changed 3 years ago by Daniel Osborne <daniel@…>

The paths are incorrect in the original patch file, I apologize for that.
I attached a new patch with the corrected paths (that's what I get for adjusting them myself).

comment:4 Changed 3 years ago by beirdo

I have an updated patch for you to try, and hope to have it posted tomorrow.

comment:5 Changed 3 years ago by kormoc

  • Milestone changed from unknown to 0.25

comment:6 Changed 3 years ago by beirdo

  • Resolution set to Fixed
  • Status changed from assigned to closed

Closed by f33865d992e668f74d3d592b0d3917e96b1ff254 (in mythweb) and 7909253bb15d4fa8f64c20c58732f9cc395cc10c (in mythtv)

This is only in master, not fixes/0.24

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.