Opened 14 years ago

Closed 13 years ago

#9464 closed Patch - Bug Fix (Fixed)

RSS output from MythWeb is invalid for programs such as "Law & Order"

Reported by: mattpyne@… Owned by: Raymond Wagner
Priority: minor Milestone: 0.25
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords: RSS
Cc: Ticket locked: yes

Description

The FeedItem?.php does not correctly covert incoming strings into valid XML. It does not deal with strings that contain <,> or &.

Attachments (1)

patch2.diff​ (1018 bytes) - added by anonymous 14 years ago.
Function to replace <,>,& with XML escape sequences.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by anonymous

Attachment: patch2.diff​ added

Function to replace <,>,& with XML escape sequences.

comment:1 Changed 14 years ago by Kenni Lund [kenni a kelu dot dk]

Status: new → assigned

comment:2 Changed 13 years ago by Raymond Wagner

Milestone: unknown → 0.25
Owner: changed from Rob Smith to Raymond Wagner

Cleanup RSS special characters

This sanitizes the content output by the RSS/ATOM generator using the built in htmlspecialchars() function.

Fixes #9464

Branch: master Changeset: 08563e3631d145fb940772e6f0c683a08d55295d

comment:3 Changed 13 years ago by Raymond Wagner

Resolution: → Fixed
Status: assigned → closed

comment:4 Changed 13 years ago by jonas@…

Resolution: Fixed
Status: closed → new

This bug also affects 0.24-fixes

An example : 

...
<item>
<title>NCIS - Mr & Ms Smith</title>
<link>http://192.168.0.2/mythweb/tv/detail/1056/1327699200</link>
<pubDate>Fri, 27 Jan 2012 22:30:00 +0100</pubDate>
<description><![CDATA[Un officier de marine a été abattu au volant de sa voiture, sur l'autoroute, tandis qu'il discutait au téléphone avec son épouse. Le NCIS est chargé de l'affaire. La victime serait un certain Jerry Smith, mais en interrogeant son supérieur, l'équipe d'enquêteurs découvre qu'il existe un second Jerry Smith, bien en vie celui-là. Le mort menait-il une double vie ? Les empreintes du cadavre prouvent que c'est bien le véritable Smith qui a été assassiné. L'autre se nomme en réalité John Kirby. Les deux hommes ont servi ensemble par le passé et auraient échangé leurs identités et leurs fonctions. Reste à découvrir le mobile du meurtre... ]]></description>
</item>
...

Mythweb on ubuntu Ubuntu 10.04.3 LTS

Package version : 2:0.24.1+fixes.20110930.f006f90-0ubuntu0mythbuntu1

comment:5 Changed 13 years ago by beirdo

Resolution: → Fixed
Status: new → closed
Ticket locked: set

This will remain not fixes in 0.24.

Note: See TracTickets for help on using tickets.