Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#9539 closed Patch - Bug Fix (fixed)

Patchs to improve "Watch Recordings" screen performance

Reported by: billstuff2001@… Owned by: stuartm
Priority: major Milestone: 0.24.1
Component: MythTV - General Version: Master Head
Severity: high Keywords:
Cc: Ticket locked: no

Description

In the Watch Recordings screen, each time you select a new group updateGroupInfo() is called which makes a DB query to get the filesize for *each* recoding in the group. This hurts performance for groups with many recordings, and for past recordings this value will rarely change.

206-SkipQueryFilesize?.patch bypasses this query if possible.

207-Skip_updateGroupInfo.patch bypasses this entire function call if possible

Attachments (2)

206-SkipQueryFilesize.patch (847 bytes) - added by billstuff2001@… 3 years ago.
207-Skip_updateGroupInfo.patch (646 bytes) - added by billstuff2001@… 3 years ago.

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by billstuff2001@…

Changed 3 years ago by billstuff2001@…

comment:1 Changed 3 years ago by wagnerrp

  • Owner set to stuartm
  • Status changed from new to assigned
  • Version changed from Unspecified to Trunk Head

comment:2 Changed 3 years ago by stuartm

  • Milestone changed from unknown to 0.24.1
  • Priority changed from minor to major
  • Severity changed from medium to high
  • Status changed from assigned to accepted

comment:3 Changed 3 years ago by Github

Bypass filesize query on recording if possible. Refs #9539

Signed-off-by: Stuart Morgan <smorgan@…>

Branch: master
Changeset: cb1911aa1d647a9ddaf22338230d6421c2df6e80

comment:4 Changed 3 years ago by Github

  • Resolution set to fixed
  • Status changed from accepted to closed

Avoid updating the group info if the group hasn't changed. Closes #9539

Signed-off-by: Stuart Morgan <smorgan@…>

Branch: master
Changeset: ce71c14e2f87606a52cee2197e040a12494a3003

comment:5 Changed 3 years ago by Github

Revert "Avoid updating the group info if the group hasn't changed. Closes #9539"

The patch failed to account for the times when we're switching focus
from the recording list to the group list when we'd want to stop showing
the recording info and show the group info instead.

This reverts commit ce71c14e2f87606a52cee2197e040a12494a3003.

Branch: master
Changeset: d537de26ef2026a3d9bf2536ac1bc8cd605cdb03

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.