Opened 9 years ago

Closed 9 years ago

#9630 closed Patch - Bug Fix (Fixed)

[PATCH] commit 361f213a (Converted jobqueue threads to QThread) breaks Windows build

Reported by: Lawrence Rust <lvr@…> Owned by: beirdo
Priority: minor Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: medium Keywords: Windows
Cc: Ticket locked: no

Description

Commit 361f213a2e0a82f0465d28b731ab472a2f47c482 breaks the Windows build:

  1. jobqueue.cpp:185: error: ‘pthread_testcancel’ was not declared in this scope
  2. jobqueue.cpp:1696: error: ‘class ChildJobThread?’ has no member named ‘SetJobA’

The attached patch fixes these.

  1. Remove superfluous pthread_testcancel
  2. #undef SetJob? which is #defined in windows.h

NB This is a reminder that before including windows/h that we should be defing WIN32_LEAN_AND_MEAN

Attachments (1)

jobq.diff (726 bytes) - added by Lawrence Rust <lvr@…> 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Lawrence Rust <lvr@…>

Attachment: jobq.diff added

comment:1 Changed 9 years ago by beirdo

Owner: set to beirdo
Status: newaccepted

comment:2 Changed 9 years ago by markk

Milestone: unknown0.25
Resolution: Fixed
Status: acceptedclosed

Fixed in e887abeafcde33887e01

NB I tried the WIN32_LEAN_AND_MEAN approach and it broke compilation in at least 3 places before I decided the obvious fix was the patch of least resistance at this time.

Note: See TracTickets for help on using tickets.