Opened 9 years ago

Closed 6 years ago

#9706 closed Patch - Feature (Won't Fix)

Theme Control of OSD Timeout Values

Reported by: Dave Sp <davespmyth@…> Owned by: sphery
Priority: minor Milestone: unknown
Component: MythTV - Video/OSD Rendering Version: 0.24-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

Uses theme "osd.xml" file to override the default short, medium, and long OSD timeout values.

Default values are still used if no override values are found, or if the override values are invalid.

Can be easily extended to include new OSD timeout values if/when they become defined.

Attachments (4)

osd.cpp.diff (992 bytes) - added by Dave Sp <davespmyth@…> 9 years ago.
xmlparsebase.cpp.diff (5.5 KB) - added by Dave Sp <davespmyth@…> 9 years ago.
xmlparsebase.h.diff (612 bytes) - added by Dave Sp <davespmyth@…> 9 years ago.
xmlparsebase.cpp.2.diff (5.5 KB) - added by Dave Sp <davespmyth@…> 9 years ago.
Corrected function name in QString call.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Dave Sp <davespmyth@…>

Attachment: osd.cpp.diff added

Changed 9 years ago by Dave Sp <davespmyth@…>

Attachment: xmlparsebase.cpp.diff added

Changed 9 years ago by Dave Sp <davespmyth@…>

Attachment: xmlparsebase.h.diff added

Changed 9 years ago by Dave Sp <davespmyth@…>

Attachment: xmlparsebase.cpp.2.diff added

Corrected function name in QString call.

comment:1 Changed 9 years ago by sphery

Owner: changed from markk to sphery
Status: newaccepted

comment:2 Changed 6 years ago by stuartm

Resolution: Won't Fix
Status: acceptedclosed

I think this is the wrong approach. Either these values are controlled by the user through settings, or my preferred approach is that we used fixed defaults that work for everyone. The OSD can always be dismissed early by the press of a button.

Having the theme set the timeouts just doesn't make much sense to me, should a user have to change their entire theme just to read the OSD before it disappears? What happens when the theme they prefer visually uses timeout values that are just too short?

Note: See TracTickets for help on using tickets.